| Summary: | RenderThemeIOS should use RenderTheme's color cache instead of its own | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Timothy Hatcher <timothy> | ||||||||||||||
| Component: | WebCore Misc. | Assignee: | Timothy Hatcher <timothy> | ||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||
| Severity: | Normal | CC: | bdakin, commit-queue, ews-watchlist, megan_gardner, thorton, webkit-bug-importer, wenson_hsieh | ||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||
| Version: | WebKit Local Build | ||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||
| OS: | Unspecified | ||||||||||||||||
| Attachments: |
|
||||||||||||||||
|
Description
Timothy Hatcher
2019-02-19 11:37:04 PST
Created attachment 362405 [details]
Patch
Created attachment 362407 [details]
Patch
Comment on attachment 362407 [details] Patch Attachment 362407 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/11207258 New failing tests: fast/css/apple-system-colors.html fast/viewport/ios/device-width-viewport-after-changing-view-scale.html Created attachment 362426 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Created attachment 362433 [details]
Patch
Attachment 362433 [details] did not pass style-queue:
ERROR: Source/WebCore/css/parser/CSSPropertyParser.cpp:170: Line contains only semicolon. If this should be an empty statement, use { } instead. [whitespace/semicolon] [5]
Total errors found: 1 in 12 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 362433 [details] Patch Attachment 362433 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/11210414 New failing tests: fast/css/apple-system-colors.html Created attachment 362458 [details]
Archive of layout-test-results from ews201 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews201 Port: win-future Platform: CYGWIN_NT-6.1-2.10.0-0.325-5-3-x86_64-64bit
Created attachment 362477 [details]
Patch
Attachment 362477 [details] did not pass style-queue:
ERROR: Source/WebCore/css/parser/CSSPropertyParser.cpp:170: Line contains only semicolon. If this should be an empty statement, use { } instead. [whitespace/semicolon] [5]
Total errors found: 1 in 13 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 362477 [details] Patch Clearing flags on attachment: 362477 Committed r241825: <https://trac.webkit.org/changeset/241825> All reviewed patches have been landed. Closing bug. |