Bug 194793

Summary:

Web Inspector: Provide a way to avoid a recording auto-stop on reload

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

Web Inspector

Assignee:

Joseph Pecoraro <joepeck>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, inspector-bugzilla-changes, joepeck, mattbaker, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

194956

Attachments:

Description	Flags
[PATCH] Proposed Fix	mattbaker: review+
[PATCH] For Landing	none

Joseph Pecoraro

Reported 2019-02-18 14:59:03 PST

Provide a way to avoid a recording auto-stop on reload Often with Timelines I want to record a load, interact with the page and stop. However with since there is an auto stop mechanism (dead time / max timeout) I have no way of guaranteeing the recording won't stop before the end of my interactions. For starters, a way to record without auto-stop, or disable / relax the auto-stop would be great.

Attachments
[PATCH] Proposed Fix (9.45 KB, patch) 2019-02-18 15:01 PST, Joseph Pecoraro	mattbaker: review+	Details Formatted Diff Diff
[PATCH] For Landing (10.65 KB, patch) 2019-02-18 15:57 PST, Joseph Pecoraro	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Joseph Pecoraro

Comment 1 2019-02-18 15:01:04 PST

Created attachment 362343 [details] [PATCH] Proposed Fix This has bugged me for a very long time, this gives me at least one way to avoid an auto-stop.

Matt Baker

Comment 2 2019-02-18 15:17:55 PST

Comment on attachment 362343 [details] [PATCH] Proposed Fix r=me, I've also wanted this! I think we could potentially iterate on this UI in the future, but it's a good start. Right now it requires knowing the keyboard shortcut, and pressing override within a potentially very brief window. My only comment before landing is to fix the "continue" button appearance in dark mode. It's current black-on-darkgray.

Joseph Pecoraro

Comment 3 2019-02-18 15:57:37 PST

> My only comment before landing is to fix the "continue" button appearance in > dark mode. It's current black-on-darkgray. Good catch, fixed.

Joseph Pecoraro

Comment 4 2019-02-18 15:57:59 PST

Created attachment 362352 [details] [PATCH] For Landing

WebKit Commit Bot

Comment 5 2019-02-18 16:52:46 PST

Comment on attachment 362352 [details] [PATCH] For Landing Clearing flags on attachment: 362352 Committed r241750: <https://trac.webkit.org/changeset/241750>

Radar WebKit Bug Importer

Comment 6 2019-02-18 17:31:09 PST

<rdar://problem/48184907>

Note You need to log in before you can comment on or make changes to this bug.