Bug 194789

Summary: Web Inspector: Styles: typing ";" shouldn't focus on the next property when there's open parenthesis or comment
Product: WebKit Reporter: Nikita Vasilyev <nvasilyev>
Component: Web InspectorAssignee: Nikita Vasilyev <nvasilyev>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, inspector-bugzilla-changes, mattbaker, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Nikita Vasilyev
Reported 2019-02-18 14:01:06 PST
We've had this for a while: Bug 178498: Web Inspector: Styles Redesign: Typing semicolon at the end of value should move to the next property Now that I added better detection of unbalanced characters, we should use it for this case as well.
Attachments
Patch (2.13 KB, patch)
2019-02-18 14:02 PST, Nikita Vasilyev 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-02-18 14:01:41 PST
<rdar://problem/48177447>
Nikita Vasilyev
Comment 2 2019-02-18 14:02:56 PST
Created attachment 362329 [details] Patch
Matt Baker
Comment 3 2019-02-18 14:12:44 PST
Comment on attachment 362329 [details] Patch r=me, nice!
WebKit Commit Bot
Comment 4 2019-02-18 14:46:00 PST
Comment on attachment 362329 [details] Patch Clearing flags on attachment: 362329 Committed r241740: <https://trac.webkit.org/changeset/241740>
WebKit Commit Bot
Comment 5 2019-02-18 14:46:02 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.