Bug 194789

Summary:

Web Inspector: Styles: typing ";" shouldn't focus on the next property when there's open parenthesis or comment

Product:

WebKit

Reporter:

Nikita Vasilyev <nvasilyev>

Component:

Web Inspector

Assignee:

Nikita Vasilyev <nvasilyev>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, inspector-bugzilla-changes, mattbaker, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none

Description Nikita Vasilyev 2019-02-18 14:01:06 PST

We've had this for a while:
Bug 178498: Web Inspector: Styles Redesign: Typing semicolon at the end of value should move to the next property

Now that I added better detection of unbalanced characters, we should use it for this case as well.

Comment 1 Radar WebKit Bug Importer 2019-02-18 14:01:41 PST

<rdar://problem/48177447>

Comment 2 Nikita Vasilyev 2019-02-18 14:02:56 PST

Created attachment 362329 [details]
Patch

Comment 3 Matt Baker 2019-02-18 14:12:44 PST

Comment on attachment 362329 [details]
Patch

r=me, nice!

Comment 4 WebKit Commit Bot 2019-02-18 14:46:00 PST

Comment on attachment 362329 [details]
Patch

Clearing flags on attachment: 362329

Committed r241740: <https://trac.webkit.org/changeset/241740>

Comment 5 WebKit Commit Bot 2019-02-18 14:46:02 PST

All reviewed patches have been landed.  Closing bug.