Bug 194772

Summary: [ARM] Fix crash with sampling profiler
Product: WebKit Reporter: Dominik Inführ <dominik.infuehr>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, fpizlo, keith_miller, mark.lam, msaboff, saam, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Dominik Inführ
Reported 2019-02-18 01:58:15 PST
[ARM] Fix crash with sampling profiler
Attachments
Patch (3.83 KB, patch)
2019-02-18 02:21 PST, Dominik Inführ 		no flags
DetailsFormatted DiffDiff
Patch (3.83 KB, patch)
2019-02-18 02:22 PST, Dominik Inführ 		no flags
DetailsFormatted DiffDiff
Patch (3.76 KB, patch)
2019-02-18 13:49 PST, Dominik Inführ 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Dominik Inführ
Comment 1 2019-02-18 02:21:33 PST
Created attachment 362275 [details] Patch
Dominik Inführ
Comment 2 2019-02-18 02:22:32 PST
Created attachment 362276 [details] Patch
Mark Lam
Comment 3 2019-02-18 09:50:51 PST
Comment on attachment 362276 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=362276&action=review r=me with fix. > Source/JavaScriptCore/assembler/MacroAssemblerARMv7.h:181 > + if (dest == ARMRegisters::sp) { This is incorrect. You only need this alternative codegen if (dest == ARMRegisters::sp && src != dest). If (dest == ARMRegisters::sp && src == dest), the implementation below would generate more optimal code. For details, see add(RegisterID rd, RegisterID rn, ARMThumbImmediate imm) in ARMv7Assembler.h.
Dominik Inführ
Comment 4 2019-02-18 13:49:57 PST
Created attachment 362327 [details] Patch
Dominik Inführ
Comment 5 2019-02-18 22:56:43 PST
Thank you very much for the review! I've extended the condition to also check for `src != dest`.
WebKit Commit Bot
Comment 6 2019-02-18 23:16:03 PST
Comment on attachment 362327 [details] Patch Clearing flags on attachment: 362327 Committed r241756: <https://trac.webkit.org/changeset/241756>
WebKit Commit Bot
Comment 7 2019-02-18 23:16:05 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2019-02-19 09:03:22 PST
<rdar://problem/48201956>
Note You need to log in before you can comment on or make changes to this bug.