| Summary: | Update WPT tests for embedded content | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Frédéric Wang (:fredw) <fred.wang> |
| Component: | New Bugs | Assignee: | Frédéric Wang (:fredw) <fred.wang> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | commit-queue, ews-watchlist, fred.wang, rbuis, rniwa, rwlbuis, tsavell, webkit-bug-importer, youennf |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=156629 https://bugs.webkit.org/show_bug.cgi?id=195466 |
||
| Bug Depends on: | 195331, 195358 | ||
| Bug Blocks: | |||
| Attachments: | |||
|
Description
Frédéric Wang (:fredw)
2019-02-18 01:05:33 PST
Created attachment 362269 [details]
Patch
Created attachment 362272 [details]
Patch
Created attachment 362274 [details]
Patch - trying with only media elements
Created attachment 362280 [details]
Patch (applies on top of 362274)
Comment on attachment 362274 [details] Patch - trying with only media elements Attachment 362274 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/11190055 Number of test failures exceeded the failure limit. Created attachment 362284 [details]
Archive of layout-test-results from ews103 for mac-highsierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103 Port: mac-highsierra Platform: Mac OS X 10.13.6
Comment on attachment 362274 [details] Patch - trying with only media elements Attachment 362274 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/11190251 Number of test failures exceeded the failure limit. Created attachment 362285 [details]
Archive of layout-test-results from ews104 for mac-highsierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6
Comment on attachment 362274 [details] Patch - trying with only media elements Attachment 362274 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/11190258 Number of test failures exceeded the failure limit. Created attachment 362286 [details]
Archive of layout-test-results from ews116 for mac-highsierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116 Port: mac-highsierra Platform: Mac OS X 10.13.6
Created attachment 362292 [details]
Patch
Comment on attachment 362292 [details]
Patch
@Youenn: I really don't know what's preventing the patch to apply on all ports but wincairo. I executed the tests on mac-wk2 and ios but I think we'll have to land the patch manually and make update expectations on other ports if necessary.
Created attachment 363091 [details]
Patch
@Youenn: Any idea why this patch cannot apply on most ports but wincairo? It's the first time I see that. Maybe it's just because the patch is too big and we should split import into smaller steps (trying only media elements in attachment 362274 [details] seemed to help).
I do not think this is the size. It might be a bad character in a file or something like that. One way to investigate this is to download the patch and locally apply it using Tools/Scripts/svn-apply. imported/w3c/web-platform-tests/html/semantics/embedded-content/the-canvas-element/size.attributes.parse.whitespace.html might have some issues. (In reply to youenn fablet from comment #15) > I do not think this is the size. > It might be a bad character in a file or something like that. > One way to investigate this is to download the patch and locally apply it > using Tools/Scripts/svn-apply. Ah, thanks for the hint. I generally use git apply, so didn't have the issue :-) (In reply to youenn fablet from comment #16) > imported/w3c/web-platform-tests/html/semantics/embedded-content/the-canvas- > element/size.attributes.parse.whitespace.html might have some issues. I'll check that later. Created attachment 363742 [details]
Patch
Comment on attachment 363742 [details] Patch Attachment 363742 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/11397716 New failing tests: imported/w3c/web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe_sandbox_anchor_download_allow_downloads_without_user_activation.sub.tentative.html imported/w3c/web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe_sandbox_anchor_download_block_downloads_without_user_activation.sub.tentative.html Created attachment 363749 [details]
Archive of layout-test-results from ews103 for mac-highsierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103 Port: mac-highsierra Platform: Mac OS X 10.13.6
Comment on attachment 363742 [details] Patch Attachment 363742 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/11397813 New failing tests: imported/w3c/web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe_sandbox_anchor_download_allow_downloads_without_user_activation.sub.tentative.html imported/w3c/web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe_sandbox_anchor_download_block_downloads_without_user_activation.sub.tentative.html Created attachment 363754 [details]
Archive of layout-test-results from ews112 for mac-highsierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112 Port: mac-highsierra Platform: Mac OS X 10.13.6
Created attachment 363774 [details]
Patch
Comment on attachment 363774 [details] Patch Clearing flags on attachment: 363774 Committed r242595: <https://trac.webkit.org/changeset/242595> All reviewed patches have been landed. Closing bug. Looks like the test imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/ready-states/autoplay.html added in https://trac.webkit.org/changeset/242595/webkit is failing constantly. History: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=imported%2Fw3c%2Fweb-platform-tests%2Fhtml%2Fsemantics%2Fembedded-content%2Fmedia-elements%2Fready-states%2Fautoplay.html Diff: --- /Volumes/Data/slave/mojave-release-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/ready-states/autoplay-expected.txt +++ /Volumes/Data/slave/mojave-release-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/ready-states/autoplay-actual.txt @@ -1,12 +1,12 @@ FAIL audio.autoplay assert_array_equals: property 1, expected "play" but got "canplaythrough" FAIL audio.autoplay and load() assert_array_equals: property 1, expected "play" but got "canplaythrough" -FAIL audio.autoplay and play() assert_array_equals: property 2, expected "playing" but got "canplaythrough" +PASS audio.autoplay and play() PASS audio.autoplay and pause() PASS audio.autoplay and internal pause steps FAIL video.autoplay assert_array_equals: property 1, expected "play" but got "canplaythrough" FAIL video.autoplay and load() assert_array_equals: property 1, expected "play" but got "canplaythrough" -FAIL video.autoplay and play() assert_array_equals: property 2, expected "playing" but got "canplaythrough" +PASS video.autoplay and play() PASS video.autoplay and pause() PASS video.autoplay and internal pause steps This test is only effecting Mojave which is why it did not show up on EWS This test is also failing: imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/error-codes/error.html History: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=imported%2Fw3c%2Fweb-platform-tests%2Fhtml%2Fsemantics%2Fembedded-content%2Fmedia-elements%2Ferror-codes%2Ferror.html Filed this to track those two test failures: https://bugs.webkit.org/show_bug.cgi?id=195466 Comment on attachment 363774 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=363774&action=review > LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-embed-element/embed-represent-nothing-04.html:17 > + <object type="application/x-shockwave-flash"> This is a bad test, because it depends on Flash. In fact, WebKitTestRunner release asserts when running it on a machine with Flash installed. |