Summary: | [JSC] Shrink UnlinkedFunctionExecutable | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||||
Component: | JavaScriptCore | Assignee: | Yusuke Suzuki <ysuzuki> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | ews-watchlist, guijemont, guijemont+jsc-armv7-ews, hi, joepeck, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=174212 | ||||||||
Attachments: |
|
Description
Yusuke Suzuki
2019-02-15 17:46:43 PST
Created attachment 362197 [details]
Patch
Comment on attachment 362197 [details]
Patch
Need to check the test. But it is strange because the test thinks source URL directive should be used even for function constructor.
Created attachment 362202 [details]
Patch
Comment on attachment 362202 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=362202&action=review r=me > Source/JavaScriptCore/bytecode/UnlinkedFunctionExecutable.cpp:45 > +static_assert(sizeof(UnlinkedFunctionExecutable) <= 128, "UnlinkedFunctionExecutable should fit in a 128-byte cell to keep allocated block only one just after initializing JSGlobalObject."); I would rephrase the message as "UnlinkedFunctionExecutable should fit in a 128-byte cell to keep allocated blocks count to only one after initializing JSGlobalObject." Comment on attachment 362202 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=362202&action=review Thank you! >> Source/JavaScriptCore/bytecode/UnlinkedFunctionExecutable.cpp:45 >> +static_assert(sizeof(UnlinkedFunctionExecutable) <= 128, "UnlinkedFunctionExecutable should fit in a 128-byte cell to keep allocated block only one just after initializing JSGlobalObject."); > > I would rephrase the message as "UnlinkedFunctionExecutable should fit in a 128-byte cell to keep allocated blocks count to only one after initializing JSGlobalObject." Sounds nice! Fixed. Committed r241645: <https://trac.webkit.org/changeset/241645> |