Bug 194730

Summary: NetworkLoad should cancel its task at destruction time
Product: WebKit Reporter: youenn fablet <youennf>
Component: Page LoadingAssignee: youenn fablet <youennf>
Status: RESOLVED WONTFIX    
Severity: Normal CC: achristensen, beidson, cdumez, ggaren, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch achristensen: review-

Description youenn fablet 2019-02-15 16:14:36 PST 
NetworkLoad should cancel its task at destruction time
Comment 1 youenn fablet 2019-02-15 16:17:22 PST 
Created attachment 362176 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2019-02-15 16:17:42 PST 
<rdar://problem/48128564>
Comment 3 Geoffrey Garen 2019-02-15 16:24:30 PST 
Comment on attachment 362176 [details]
Patch

r=me
Comment 4 Alex Christensen 2019-02-15 16:26:50 PST 
Comment on attachment 362176 [details]
Patch

Nope.  We don't want to do this.  When the task is destroyed it will effectively cancel.

What we want to do instead is null check m_client in NetworkDataTask::shouldCaptureExtraNetworkLoadMetrics
Comment 5 youenn fablet 2019-02-15 16:38:55 PST 
WONTFIX for now, let's do null check and revisit this issue if needed.
Comment 6 youenn fablet 2019-02-15 16:41:46 PST 
In the meantime, I filed https://bugs.webkit.org/show_bug.cgi?id=194732.