Bug 194686

Summary: Refactor EditingStyle::textDirection to return an Optional<WritingDirection> instead of a bool
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: HTML EditingAssignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, rniwa, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: DoNotImportToRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Wenson Hsieh
Reported 2019-02-14 17:37:42 PST
bool textDirection(WritingDirection&) is a little clunky. A more modern idiom for these kinds of methods is to return an Optional<T> instead, where nullopt corresponds to a false return value.
Attachments
Patch (8.33 KB, patch)
2019-02-14 18:35 PST, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2019-02-14 18:35:08 PST
Created attachment 362089 [details] Patch
WebKit Commit Bot
Comment 2 2019-02-15 08:52:39 PST
Comment on attachment 362089 [details] Patch Clearing flags on attachment: 362089 Committed r241588: <https://trac.webkit.org/changeset/241588>
WebKit Commit Bot
Comment 3 2019-02-15 08:52:41 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.