Bug 194642

Summary: Web Inspector: remove unused parameter in _parseStylePropertyPayload
Product: WebKit Reporter: Nikita Vasilyev <nvasilyev>
Component: Web InspectorAssignee: Nikita Vasilyev <nvasilyev>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hi, inspector-bugzilla-changes
Priority: P2 Keywords: DoNotImportToRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
hi: review+
Patch for landing none

Nikita Vasilyev
Reported 2019-02-13 21:57:06 PST
.
Attachments
Patch (2.33 KB, patch)
2019-02-13 22:00 PST, Nikita Vasilyev 		hi: review+
DetailsFormatted DiffDiff
Patch for landing (2.26 KB, patch)
2019-02-15 15:00 PST, Nikita Vasilyev 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Nikita Vasilyev
Comment 1 2019-02-13 22:00:02 PST
Created attachment 361996 [details] Patch
Devin Rousso
Comment 2 2019-02-13 23:22:55 PST
Comment on attachment 361996 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=361996&action=review rs=me, it took a minute to understand what you meant by _this_ in "used by this method", but I see what you mean. The `styleText` parameter was never used :P > Source/WebInspectorUI/UserInterface/Models/DOMNodeStyles.js:509 > + _parseStylePropertyPayload(payload, index, styleDeclaration) There should also (technically) be a ChangeLog entry for this. > Source/WebInspectorUI/UserInterface/Models/DOMNodeStyles.js:665 > + var property = this._parseStylePropertyPayload(propertyPayload, i, styleDeclaration); Style: `let`. > Source/WebInspectorUI/UserInterface/Models/DOMNodeStyles.js:669 > + var text = payload.cssText; Style: `let`.
Nikita Vasilyev
Comment 3 2019-02-15 15:00:09 PST
Created attachment 362162 [details] Patch for landing
WebKit Commit Bot
Comment 4 2019-02-15 15:37:56 PST
Comment on attachment 362162 [details] Patch for landing Clearing flags on attachment: 362162 Committed r241621: <https://trac.webkit.org/changeset/241621>
WebKit Commit Bot
Comment 5 2019-02-15 15:37:58 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.