Bug 194590
| Summary: | [GTK] Do not silently disable GIR for cross builds | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Rasmus Thomsen <bugs-webkit> |
| Component: | CMake | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | aperez, bugs-noreply, don.olmstead, mcatanzaro |
| Priority: | P2 | ||
| Version: | WebKit Local Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Rasmus Thomsen
Hello,
Could the silent disabling of GIR in OptionsGTK.cmake be removed? Void Linux has recently enabled GIR compilation in cross builds using the methods already used by the Yocto Project and Buildroot (namely running g-ir-* through qemu), so we have to patch it out:
--- Source/cmake/OptionsGTK.cmake.orig 2019-02-10 18:04:07.898417778 +0100
+++ Source/cmake/OptionsGTK.cmake 2019-02-10 18:04:36.673415569 +0100
@@ -357,7 +357,6 @@
# Override the cached variables, gtk-doc and gobject-introspection do not really work when cross-building.
if (CMAKE_CROSSCOMPILING)
set(ENABLE_GTKDOC OFF)
- set(ENABLE_INTROSPECTION OFF)
endif ()
# Override the cached variable, gtk-doc does not really work when building on Mac.
The cross builds work fine for us now on armv{5,6,7} and aarch64.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Rasmus Thomsen
FWIW, I guess the silent disabling GTK_DOC should be disabled too and replaced by at least a warning?
Michael Catanzaro
Looks like this is gone nowadays.