Bug 194577

Summary: JSScript needs to retain its cache path NSURL*
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, fpizlo, ggaren, gskachkov, guijemont, keith_miller, mark.lam, msaboff, rmorisset, thorton, ticaiolima, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
patch
thorton: review+
patch for landing
none
patch for landing none

Saam Barati
Reported 2019-02-12 17:58:22 PST
...
Attachments
patch (1.54 KB, patch)
2019-02-12 18:09 PST, Saam Barati 		no flags
DetailsFormatted DiffDiff
patch (2.09 KB, patch)
2019-02-12 18:13 PST, Saam Barati 		thorton: review+
DetailsFormatted DiffDiff
patch for landing (2.08 KB, patch)
2019-02-12 18:16 PST, Saam Barati 		no flags
DetailsFormatted DiffDiff
patch for landing (1.87 KB, patch)
2019-02-12 18:17 PST, Saam Barati 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2019-02-12 18:09:57 PST
Created attachment 361882 [details] patch
Keith Miller
Comment 2 2019-02-12 18:12:27 PST
Comment on attachment 361882 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=361882&action=review > Source/JavaScriptCore/API/JSScript.mm:109 > + result->m_cachePath = [cachePath retain]; Can we make m_cachePath be a retainPtr?
Saam Barati
Comment 3 2019-02-12 18:13:46 PST
Created attachment 361884 [details] patch
Tim Horton
Comment 4 2019-02-12 18:14:27 PST
Comment on attachment 361884 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=361884&action=review > Source/JavaScriptCore/API/JSScript.mm:132 > + int fd = open(m_cachePath.get().path.UTF8String, O_RDONLY); In WK2 we usually would just [m_cachePath path].UTF8String but it's up to you.
Saam Barati
Comment 5 2019-02-12 18:16:49 PST
Created attachment 361885 [details] patch for landing
Saam Barati
Comment 6 2019-02-12 18:17:03 PST
Comment on attachment 361884 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=361884&action=review >> Source/JavaScriptCore/API/JSScript.mm:132 >> + int fd = open(m_cachePath.get().path.UTF8String, O_RDONLY); > > In WK2 we usually would just [m_cachePath path].UTF8String but it's up to you. Sounds good. Fixed.
Saam Barati
Comment 7 2019-02-12 18:17:44 PST
Created attachment 361886 [details] patch for landing
WebKit Commit Bot
Comment 8 2019-02-12 22:34:49 PST
Comment on attachment 361886 [details] patch for landing Clearing flags on attachment: 361886 Committed r241340: <https://trac.webkit.org/changeset/241340>
WebKit Commit Bot
Comment 9 2019-02-12 22:34:51 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 10 2019-02-12 22:35:24 PST
<rdar://problem/48028610>
Note You need to log in before you can comment on or make changes to this bug.