Bug 194572

Summary:

[ews-app] Generate status-bubble

Product:

WebKit

Reporter:

Aakash Jain <aakash_jain>

Component:

Tools / Tests

Assignee:

Aakash Jain <aakash_jain>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, ap, ews-watchlist, kocsen_chung, lforschler, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=194571

Attachments:

Description	Flags
Proposed patch	none
Proposed patch	lforschler: review+
Archive of layout-test-results from ews121 for ios-simulator-wk2	none

Aakash Jain

Reported 2019-02-12 17:27:35 PST

ews-app should display status-bubble corresponding to the patch.

Attachments
Proposed patch (3.70 KB, patch) 2019-02-12 17:33 PST, Aakash Jain	no flags	Details Formatted Diff Diff
Proposed patch (3.79 KB, patch) 2019-02-12 17:58 PST, Aakash Jain	lforschler: review+	Details Formatted Diff Diff
Archive of layout-test-results from ews121 for ios-simulator-wk2 (10.83 MB, application/zip) 2019-02-12 22:29 PST, EWS Watchlist	no flags	Details
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Aakash Jain

Comment 1 2019-02-12 17:33:20 PST

Created attachment 361874 [details] Proposed patch Basic version of status bubbles.

Aakash Jain

Comment 2 2019-02-12 17:58:33 PST

Created attachment 361880 [details] Proposed patch

Aakash Jain

Comment 3 2019-02-12 18:00:14 PST

Sample bubble: https://ews.webkit-uat.org/status-bubble/361733/

EWS Watchlist

Comment 4 2019-02-12 22:29:04 PST Comment hidden (obsolete)

Comment on attachment 361880 [details] Proposed patch Attachment 361880 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/11130830 New failing tests: imported/w3c/web-platform-tests/webrtc/simplecall-no-ssrcs.https.html

EWS Watchlist

Comment 5 2019-02-12 22:29:06 PST Comment hidden (obsolete)

Created attachment 361896 [details] Archive of layout-test-results from ews121 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6

Lucas Forschler

Comment 6 2019-02-13 10:22:40 PST

Comment on attachment 361880 [details] Proposed patch can you update all your TODO items with bugzilla bugs?

Aakash Jain

Comment 7 2019-02-13 10:55:09 PST

> can you update all your TODO items with bugzilla bugs? done

Aakash Jain

Comment 8 2019-02-13 10:55:30 PST

Committed r241443: <https://trac.webkit.org/changeset/241443>

Radar WebKit Bug Importer

Comment 9 2019-02-13 11:12:16 PST

<rdar://problem/48044822>

Note You need to log in before you can comment on or make changes to this bug.