Bug 194549 – Web Inspector: Timeline.prototype.recordsInTimeRange uses a property most records do not have

• Component: Web Inspector
• Status: RESOLVED FIXED

[Joseph Pecoraro]

Timeline.prototype.recordsInTimeRange uses a property most records do not have

Change `record.timestamp` to `record.startTime`.

  • Not all records have a timestamp. They do have a startTime/endTime
  • Those that do, set the startTime/endTime to the timestamp value

[Joseph Pecoraro]

Created attachment 361818 [details]
[PATCH] Proposed Fix

[Devin Rousso]

Comment on attachment 361818 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=361818&action=review

rs=me

> Source/WebInspectorUI/UserInterface/Models/Timeline.js:99
> +        let upperIndex = this._records.upperBound(endTime, (time, record) => time - record.startTime);

Should this be `endTime`?  If it's `startTime`, that means we'd include records that began in the range, but finished outside of the range.  If it's `endTime`, then we'd exclude those records.

[Joseph Pecoraro]

Comment on attachment 361818 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=361818&action=review

>> Source/WebInspectorUI/UserInterface/Models/Timeline.js:99
>> +        let upperIndex = this._records.upperBound(endTime, (time, record) => time - record.startTime);
> 
> Should this be `endTime`?  If it's `startTime`, that means we'd include records that began in the range, but finished outside of the range.  If it's `endTime`, then we'd exclude those records.

I'd expect records that are even partially in the range. The lowerIndex could use `record.endTime`, but there is `includeRecordBeforeStart`.

[WebKit Commit Bot]

Comment on attachment 361818 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 361818

Committed r241315: <https://trac.webkit.org/changeset/241315>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/48012450>