Bug 194535

Summary:

CodeBlocks read from disk should not be re-written

Product:

WebKit

Reporter:

Tadeu Zagallo <tzagallo>

Component:

JavaScriptCore

Assignee:

Tadeu Zagallo <tzagallo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, ews-watchlist, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	msaboff: review+, commit-queue: commit-queue-

Tadeu Zagallo

Reported 2019-02-12 05:25:54 PST

...

Attachments
Patch (2.73 KB, patch) 2019-02-12 05:27 PST, Tadeu Zagallo	msaboff: review+ commit-queue: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Tadeu Zagallo

Comment 1 2019-02-12 05:27:42 PST

Created attachment 361792 [details] Patch

Michael Saboff

Comment 2 2019-02-13 10:24:15 PST

Comment on attachment 361792 [details] Patch r=me

WebKit Commit Bot

Comment 3 2019-02-13 10:50:22 PST

Comment on attachment 361792 [details] Patch Rejecting attachment 361792 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 361792, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=361792&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=194535&ctype=xml&excludefield=attachmentdata Processing 1 patch from 1 bug. Updating working directory Processing patch 361792 from bug 194535. Fetching: https://bugs.webkit.org/attachment.cgi?id=361792 Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Committing to http://svn.webkit.org/repository/webkit/trunk ... M Source/JavaScriptCore/ChangeLog M Source/JavaScriptCore/runtime/CodeCache.cpp M Source/JavaScriptCore/runtime/CodeCache.h Committed r241442 fatal: Unable to create '/Volumes/Data/EWS/WebKit/.git/svn/refs/remotes/origin/master/index.lock': File exists. Another git process seems to be running in this repository, e.g. an editor opened by 'git commit'. Please make sure all processes are terminated then try again. If it still fails, a git process may have crashed in this repository earlier: remove the file manually to continue. write-tree: command returned error: 128 Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Committing to http://svn.webkit.org/repository/webkit/trunk ... M Source/JavaScriptCore/ChangeLog M Source/JavaScriptCore/runtime/CodeCache.cpp M Source/JavaScriptCore/runtime/CodeCache.h Committed r241442 fatal: Unable to create '/Volumes/Data/EWS/WebKit/.git/svn/refs/remotes/origin/master/index.lock': File exists. Another git process seems to be running in this repository, e.g. an editor opened by 'git commit'. Please make sure all processes are terminated then try again. If it still fails, a git process may have crashed in this repository earlier: remove the file manually to continue. write-tree: command returned error: 128 Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Updating OpenSource From https://git.webkit.org/git/WebKit a68a1b1e94c..5ff49f45c34 master -> origin/master Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 241437 = a68a1b1e94ceb6c7436139f5348f18141ae0b15a r241440 = 64539b902bf2cc5c451511d0fde4fbe959b92f6e r241441 = 5ff49f45c34c2eb581c95662e359560130c66457 Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: https://webkit-queues.webkit.org/results/11136301

Tadeu Zagallo

Comment 4 2019-02-14 09:16:14 PST

Landed in r241442: <https://trac.webkit.org/r241442>

Radar WebKit Bug Importer

Comment 5 2019-02-14 09:17:25 PST

<rdar://problem/48075964>

Note You need to log in before you can comment on or make changes to this bug.