Bug 194531 – Move UIWebTouchEventsGestureRecognizer.activeTouchesByIdentifier to SPI

• Component: New Bugs
• Status: RESOLVED FIXED

[Antoine Quint]

Move UIWebTouchEventsGestureRecognizer.activeTouchesByIdentifier to SPI

[Antoine Quint]

<rdar://problem/47714562>

[Antoine Quint]

Created attachment 361784 [details]
Patch

[Antoine Quint]

<rdar://problem/47714562>

[EWS Watchlist]

Comment on attachment 361784 [details]
Patch

Attachment 361784 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/11120170

Number of test failures exceeded the failure limit.

[EWS Watchlist]

Created attachment 361787 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6

[Dean Jackson]

Comment on attachment 361784 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=361784&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:-1153
> -    // FIXME: <rdar://problem/47714562>
> -    if (![_touchEventGestureRecognizer respondsToSelector:@selector(activeTouchesByIdentifier)])
> -        return;
> -

I think you still need this for Open Source compiles.

[Antoine Quint]

Committed r241433: <https://trac.webkit.org/changeset/241433>

[Truitt Savell]

Reverted r241433 for reason:

Broke internal builds.

Committed r241435: <https://trac.webkit.org/changeset/241435>

[Antoine Quint]

Committed r241865: <https://trac.webkit.org/changeset/241865>

[Antoine Quint]

Reopening to attach new patch.

[Antoine Quint]

Created attachment 362631 [details]
Patch

[Tim Horton]

Comment on attachment 362631 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362631&action=review

> Source/WTF/wtf/Platform.h:1516
> +#if PLATFORM(IOS_FAMILY) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 130000

What about watchOS

[Antoine Quint]

(In reply to Tim Horton from comment #12)
> Comment on attachment 362631 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=362631&action=review
> 
> > Source/WTF/wtf/Platform.h:1516
> > +#if PLATFORM(IOS_FAMILY) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 130000
> 
> What about watchOS

ENABLE_POINTER_EVENTS is currently not defined for watchOS

[Tim Horton]

(In reply to Antoine Quint from comment #13)
> (In reply to Tim Horton from comment #12)
> > Comment on attachment 362631 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=362631&action=review
> > 
> > > Source/WTF/wtf/Platform.h:1516
> > > +#if PLATFORM(IOS_FAMILY) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 130000
> > 
> > What about watchOS
> 
> ENABLE_POINTER_EVENTS is currently not defined for watchOS

✅

[WebKit Commit Bot]

Comment on attachment 362631 [details]
Patch

Clearing flags on attachment: 362631

Committed r241900: <https://trac.webkit.org/changeset/241900>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.