Bug 194518

Summary:

[ews-app] Add method to fetch patch

Product:

WebKit

Reporter:

Aakash Jain <aakash_jain>

Component:

Tools / Tests

Assignee:

Aakash Jain <aakash_jain>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, ap, commit-queue, ews-watchlist, lforschler, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Proposed patch	none

Aakash Jain

Reported 2019-02-11 15:36:25 PST

Add method to fetch patch object given patch id.

Attachments
Proposed patch (1.30 KB, patch) 2019-02-11 15:38 PST, Aakash Jain	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Aakash Jain

Comment 1 2019-02-11 15:38:47 PST

Created attachment 361721 [details] Proposed patch

EWS Watchlist

Comment 2 2019-02-11 15:42:09 PST Comment hidden (obsolete)

Attachment 361721 [details] did not pass style-queue: ERROR: Tools/BuildSlaveSupport/ews-app/ews/models/patch.py:80: [Patch.get_patch] Class 'Patch' has no 'objects' member [pylint/E1101] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.

WebKit Commit Bot

Comment 3 2019-02-12 16:02:30 PST

Comment on attachment 361721 [details] Proposed patch Clearing flags on attachment: 361721 Committed r241326: <https://trac.webkit.org/changeset/241326>

WebKit Commit Bot

Comment 4 2019-02-12 16:02:31 PST

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 5 2019-02-12 16:03:29 PST

<rdar://problem/48019402>

Note You need to log in before you can comment on or make changes to this bug.