Bug 194509

Summary: [css-grid] Indefinite percentage in fit-content track size is treated as 0
Product: WebKit Reporter: Oriol Brufau <obrufau>
Component: CSSAssignee: Oriol Brufau <obrufau>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, jfernandez, rego, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.chromium.org/p/chromium/issues/detail?id=927865
Attachments:
Description Flags
testcase
none
Patch none

Oriol Brufau
Reported 2019-02-11 11:28:37 PST
Created attachment 361698 [details] testcase What steps will reproduce the problem? (1) Create a css grid sized under a max-content constraint, with a fit-content(100%) column size. (2) Place a grid item inside it, with a min-content contribution of 50px and a max-content contribution of 100px. What is the expected result? The grid is 100px wide. What happens instead? The grid is 50px wide. According to https://github.com/w3c/csswg-drafts/issues/3585, fit-content() with an indefinite percentage should be treated as minmax(auto,max-content) instead of resolving the percentage against 0. Firefox and Edge already did this, and Blink has been fixed in https://crbug.com/927865
Attachments
testcase (304 bytes, text/html)
2019-02-11 11:28 PST, Oriol Brufau 		no flags
Details
Patch (8.90 KB, patch)
2019-02-11 11:39 PST, Oriol Brufau 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Oriol Brufau
Comment 1 2019-02-11 11:39:06 PST
Created attachment 361700 [details] Patch
WebKit Commit Bot
Comment 2 2019-02-18 15:41:01 PST
Comment on attachment 361700 [details] Patch Clearing flags on attachment: 361700 Committed r241746: <https://trac.webkit.org/changeset/241746>
WebKit Commit Bot
Comment 3 2019-02-18 15:41:02 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4 2019-02-18 15:53:20 PST
<rdar://problem/48181660>
Note You need to log in before you can comment on or make changes to this bug.