Summary: | Remove the RELEASE_ASSERT check for duplicate cases in the BinarySwitch constructor. | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mark Lam <mark.lam> | ||||||||
Component: | JavaScriptCore | Assignee: | Mark Lam <mark.lam> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | fpizlo, keith_miller, msaboff, rmorisset, saam, tzagallo, webkit-bug-importer, ysuzuki | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 194492 | ||||||||||
Attachments: |
|
Description
Mark Lam
2019-02-10 23:34:17 PST
Created attachment 361662 [details]
proposed patch.
Created attachment 361663 [details]
proposed patch.
Created attachment 361664 [details]
proposed patch.
Comment on attachment 361664 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=361664&action=review r=me > Source/JavaScriptCore/jit/BinarySwitch.cpp:65 > + RELEASE_ASSERT(m_cases[i - 1] < m_cases[i], i, m_cases.size(), m_cases[i].value, m_cases[i].index); Why not using `ASSERT` here? Thanks for the review. I've changed the RELEASE_ASSERT to a debug ASSERT. Landed in r241267: <http://trac.webkit.org/r241267>. |