Bug 194457

Summary: Make B3Value::returnsBool() more precise
Product: WebKit Reporter: Robin Morisset <rmorisset>
Component: JavaScriptCoreAssignee: Robin Morisset <rmorisset>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
saam: review+, ews-watchlist: commit-queue-
Archive of layout-test-results from ews202 for win-future
none
Patch none

Robin Morisset
Reported 2019-02-08 15:23:50 PST
It is currently wildly imprecise for BitAnd, and knows nothing about BitOr, BitXor, Select and Identity.
Attachments
Patch (1.85 KB, patch)
2019-02-08 15:33 PST, Robin Morisset 		saam: review+
ews-watchlist: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews202 for win-future (12.87 MB, application/zip)
2019-02-08 17:39 PST, EWS Watchlist 		no flags
Details
Patch (1.85 KB, patch)
2019-02-12 14:30 PST, Robin Morisset 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Robin Morisset
Comment 1 2019-02-08 15:33:43 PST
Created attachment 361543 [details] Patch
EWS Watchlist
Comment 2 2019-02-08 17:39:26 PST
Comment on attachment 361543 [details] Patch Attachment 361543 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/11085241 New failing tests: js/dom/custom-constructors.html
EWS Watchlist
Comment 3 2019-02-08 17:39:37 PST
Created attachment 361572 [details] Archive of layout-test-results from ews202 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews202 Port: win-future Platform: CYGWIN_NT-6.1-2.10.0-0.325-5-3-x86_64-64bit
Robin Morisset
Comment 4 2019-02-12 14:30:31 PST
Created attachment 361844 [details] Patch Same patch as before, to see if I broke the windows test, or if it is just flaky.
Saam Barati
Comment 5 2019-02-12 14:36:46 PST
(In reply to Robin Morisset from comment #4) > Created attachment 361844 [details] > Patch > > Same patch as before, to see if I broke the windows test, or if it is just > flaky. You didn't break windows with this. Also, you can't mark your own patch as r+. You need to explicitly fill in the reviewer information or have someone else mark it as r+.
Robin Morisset
Comment 6 2019-02-12 18:03:41 PST
Comment on attachment 361844 [details] Patch Going to try landing it, since the windows bot looks broken. Worst case it'll be rolled back.
WebKit Commit Bot
Comment 7 2019-02-12 18:30:19 PST
Comment on attachment 361844 [details] Patch Clearing flags on attachment: 361844 Committed r241335: <https://trac.webkit.org/changeset/241335>
WebKit Commit Bot
Comment 8 2019-02-12 18:30:21 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2019-02-12 18:32:19 PST
<rdar://problem/48024287>
Note You need to log in before you can comment on or make changes to this bug.