Summary: | [Cocoa] Optimize ResourceResponse::platformLazyInit() | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||
Component: | WebKit2 | Assignee: | Chris Dumez <cdumez> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | achristensen, beidson, commit-queue, ggaren, rniwa, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Chris Dumez
2019-02-08 09:16:38 PST
Created attachment 361509 [details]
Patch
Comment on attachment 361509 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=361509&action=review > Source/WebCore/ChangeLog:22 > + This patch updates ResourceResponse::platformLazyInit() to initialize all HTTP headers at once, as soon as CommonFieldsOnly If we're doing this, why not just remove CommonFieldsOnly? (In reply to Alex Christensen from comment #2) > Comment on attachment 361509 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=361509&action=review > > > Source/WebCore/ChangeLog:22 > > + This patch updates ResourceResponse::platformLazyInit() to initialize all HTTP headers at once, as soon as CommonFieldsOnly > > If we're doing this, why not just remove CommonFieldsOnly? I would need to gather more data before doing such change. Also, this is likely not true for WebKit1 since no IPC. Comment on attachment 361509 [details]
Patch
In a follow-up, I will look into removing the double stage lazy init altogether.
Comment on attachment 361509 [details] Patch Clearing flags on attachment: 361509 Committed r241220: <https://trac.webkit.org/changeset/241220> All reviewed patches have been landed. Closing bug. |