Bug 194423

Summary: PseudoElement created for any ::before/::after selector regardless of whether a content property exists
Product: WebKit Reporter: Devin Rousso <hi>
Component: CSSAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hi, joepeck, koivisto, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Devin Rousso
Reported 2019-02-07 18:32:11 PST
If a page has a rule with ::before/::after but without a `content` property, we still create a `PseuedoElement` and attach it to the parent, and then we will immediately destroy it as there is no `content` and therefore nothing to display. We should only be creating `PseudoElement`s when we have `content` (and *not* `display: none;`).
Attachments
Patch (7.94 KB, patch)
2019-02-07 18:35 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2019-02-07 18:33:18 PST
<rdar://problem/46787260>
Devin Rousso
Comment 2 2019-02-07 18:35:28 PST
Created attachment 361484 [details] Patch
Antti Koivisto
Comment 3 2019-02-07 22:23:56 PST
Comment on attachment 361484 [details] Patch Good find, r=me
WebKit Commit Bot
Comment 4 2019-02-07 22:51:57 PST
Comment on attachment 361484 [details] Patch Clearing flags on attachment: 361484 Committed r241189: <https://trac.webkit.org/changeset/241189>
WebKit Commit Bot
Comment 5 2019-02-07 22:51:59 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.