Summary: | Fix animation rendering on the webkit.org homepage | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jon Davis <jond> | ||||
Component: | WebKit Website | Assignee: | Jon Davis <jond> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, hi, jond, nvasilyev, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Jon Davis
2019-02-07 08:58:28 PST
Created attachment 361402 [details]
Patch
Comment on attachment 361402 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=361402&action=review Could you attach a screenshot of the bug? > Websites/webkit.org/wp-content/themes/webkit/front-header.php:-103 > - @-webkit-keyframes bgspin { > - from { > - transform: translateY(-400px) rotate(0); > - -webkit-transform: translateY(-400px) rotate(0deg); > - } > - > - to { > - transform: translateY(-400px) rotate(360); > - -webkit-transform: translateY(-400px) rotate(360deg); > - } > - } > - Nice that we don't need to use -webkit- prefix here anymore. Do you know why it was jumping? Was it related to font-size changes (I see you previously used rem units)? Comment on attachment 361402 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=361402&action=review > Websites/webkit.org/wp-content/themes/webkit/front-header.php:51 > + transform: translateY(-450px); What's the reasoning behind this change? Is it just gardening? E.g. using pixels for consistency. > Websites/webkit.org/wp-content/themes/webkit/front-header.php:81 > + transform: translateY(-400px); Discussed offline. This line fixes the issue, the rest is a cleanup. I'd r+. (In reply to Nikita Vasilyev from comment #4) > Comment on attachment 361402 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=361402&action=review > > > Websites/webkit.org/wp-content/themes/webkit/front-header.php:51 > > + transform: translateY(-450px); > > What's the reasoning behind this change? Is it just gardening? E.g. using > pixels for consistency. Ignore my question. We've discussed this — pixels are used for consistency. Comment on attachment 361402 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=361402&action=review rs=me > Websites/webkit.org/wp-content/themes/webkit/front-header.php:76 > + animation-name: bgspin; If you can reproduce the bug we discussed offline about this (e.g. a reduction), please file a bug for it :) Comment on attachment 361402 [details] Patch Clearing flags on attachment: 361402 Committed r241178: <https://trac.webkit.org/changeset/241178> All reviewed patches have been landed. Closing bug. |