Bug 19438 – Transaction errors are never displayed in database query view

• Component: Web Inspector (Deprecated)
• Status: RESOLVED FIXED

[Adam Roben (:aroben)]

Transaction errors are never displayed in database query view.

To repro:
1. Go to http://webkit.org/misc/DatabaseExample.html
2. Go to the Databases panel and click on the NoteTest database
3. Enter the following text on the query input line:
INSERT INTO WebKitStickyNotes (note) VALUES (NULL)

Results:
The line of text you entered disappears, and no error is shown.

[Adam Roben (:aroben)]

Created attachment 21579 [details]
patch + changelog

[Darin Adler]

Comment on attachment 21579 [details]
patch + changelog

r=me; seems fine as is

But this seems a little strange to me. Why wouldn't we instead use two different error functions for the two different cases, and then share a common worker function?

[Adam Roben (:aroben)]

(In reply to comment #2)
> (From update of attachment 21579 [details] [edit])
> r=me; seems fine as is
> 
> But this seems a little strange to me. Why wouldn't we instead use two
> different error functions for the two different cases, and then share a common
> worker function?

Yeah, that's probably a better way to go. I guess this patch is a little too quick-n-dirty.

[Adam Roben (:aroben)]

Created attachment 21580 [details]
patch v2 + changelog

Updated to address Darin's comments.

[Darin Adler]

Comment on attachment 21580 [details]
patch v2 + changelog

r=me

[Adam Roben (:aroben)]

Committed in r34455