Bug 194378

Summary: Infinite recursion via CachedResource::~CachedResource
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Page LoadingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, cdumez, commit-queue, dbates, ews-watchlist, ggaren, japhet, rniwa, sabouhallawa, sihui_liu
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch none

Description Antti Koivisto 2019-02-07 01:07:07 PST 
Infinite recursion via ~CachedResource

Thread 0 Crashed ↩:: Dispatch queue: com.apple.main-thread
0   com.apple.WebCore             	0x7fff5ea60a9a WebCore::CachedResourceHandle<WebCore::CachedResource> WTF::HashMap<WTF::String, WebCore::CachedResourceHandle<WebCore::CachedResource>, WTF::StringHash, WTF::HashTraits<WTF::String>, WTF::HashTraits<WebCore::CachedResourceHandle<WebCore::CachedResource> > >::get<WTF::IdentityHashTranslator<WTF::HashMap<WTF::String, WebCore::CachedResourceHandle<WebCore::CachedResource>, WTF::StringHash, WTF::HashTraits<WTF::String>, WTF::HashTraits<WebCore::CachedResourceHandle<WebCore::CachedResource> > >::KeyValuePairTraits, WTF::StringHash>, WTF::String>(WTF::String const&) const + 170 (/BuildRoot/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.Internal.sdk/usr/local/include/wtf/text/StringHash.h:55)
1   com.apple.WebCore             	0x7fff5ea544fc WebCore::CachedResourceLoader::removeCachedResource(WebCore::CachedResource&) + 236 (/BuildRoot/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.Internal.sdk/usr/local/include/wtf/HashMap.h:424)
2   com.apple.WebCore             	0x7fff5d93cc3f WebCore::CachedResource::~CachedResource() + 47 (./loader/cache/CachedResource.cpp:178)
3   com.apple.WebCore             	0x7fff5ea5455e WebCore::CachedResource::~CachedResource() + 14 (./loader/cache/CachedResource.cpp:165)
4   com.apple.WebCore             	0x7fff5d8dd470 WebCore::CachedResource::unregisterHandle(WebCore::CachedResourceHandleBase*) + 176 (./loader/cache/CachedResource.cpp:624)
5   com.apple.WebCore             	0x7fff5ea54511 WebCore::CachedResourceLoader::removeCachedResource(WebCore::CachedResource&) + 257 (./loader/cache/CachedResourceHandle.cpp:55)
6   com.apple.WebCore             	0x7fff5d93cc3f WebCore::CachedResource::~CachedResource() + 47 (./loader/cache/CachedResource.cpp:178)
7   com.apple.WebCore             	0x7fff5ea5455e WebCore::CachedResource::~CachedResource() + 14 (./loader/cache/CachedResource.cpp:165)
8   com.apple.WebCore             	0x7fff5d8dd470 WebCore::CachedResource::unregisterHandle(WebCore::CachedResourceHandleBase*) + 176 (./loader/cache/CachedResource.cpp:624)
9   com.apple.WebCore             	0x7fff5ea54511 WebCore::CachedResourceLoader::removeCachedResource(WebCore::CachedResource&) + 257 (./loader/cache/CachedResourceHandle.cpp:55)
10  com.apple.WebCore             	0x7fff5d93cc3f WebCore::CachedResource::~CachedResource() + 47 (./loader/cache/CachedResource.cpp:178)
11  com.apple.WebCore             	0x7fff5ea5455e WebCore::CachedResource::~CachedResource() + 14 (./loader/cache/CachedResource.cpp:165)
12  com.apple.WebCore             	0x7fff5d8dd470 WebCore::CachedResource::unregisterHandle(WebCore::CachedResourceHandleBase*) + 176 (./loader/cache/CachedResource.cpp:624)
13  com.apple.WebCore             	0x7fff5ea54511 WebCore::CachedResourceLoader::removeCachedResource(WebCore::CachedResource&) + 257 (./loader/cache/CachedResourceHandle.cpp:55)
14  com.apple.WebCore             	0x7fff5d93cc3f WebCore::CachedResource::~CachedResource() + 47 (./loader/cache/CachedResource.cpp:178)
15  com.apple.WebCore             	0x7fff5ea5455e WebCore::CachedResource::~CachedResource() + 14 (./loader/cache/CachedResource.cpp:165)
16  com.apple.WebCore             	0x7fff5d8dd470 WebCore::CachedResource::unregisterHandle(WebCore::CachedResourceHandleBase*) + 176 (./loader/cache/CachedResource.cpp:624)
17  com.apple.WebCore             	0x7fff5ea54511 WebCore::CachedResourceLoader::removeCachedResource(WebCore::CachedResource&) + 257 (./loader/cache/CachedResourceHandle.cpp:55)
18  com.apple.WebCore             	0x7fff5d93cc3f WebCore::CachedResource::~CachedResource() + 47 (./loader/cache/CachedResource.cpp:178)
19  com.apple.WebCore             	0x7fff5ea5455e WebCore::CachedResource::~CachedResource() + 14 (./loader/cache/CachedResource.cpp:165)
20  com.apple.WebCore             	0x7fff5d8dd470 WebCore::CachedResource::unregisterHandle(WebCore::CachedResourceHandleBase*) + 176 (./loader/cache/CachedResource.cpp:624)
21  com.apple.WebCore             	0x7fff5ea54511 WebCore::CachedResourceLoader::removeCachedResource(WebCore::CachedResource&) + 257 (./loader/cache/CachedResourceHandle.cpp:55)
22  com.apple.WebCore             	0x7fff5d93cc3f WebCore::CachedResource::~CachedResource() + 47 (./loader/cache/CachedResource.cpp:178)
23  com.apple.WebCore             	0x7fff5ea5455e WebCore::CachedResource::~CachedResource() + 14 (./loader/cache/CachedResource.cpp:165)
24  com.apple.WebCore             	0x7fff5d8dd470 WebCore::CachedResource::unregisterHandle(WebCore::CachedResourceHandleBase*) + 176 (./loader/cache/CachedResource.cpp:624)
25  com.apple.WebCore             	0x7fff5ea54511 WebCore::CachedResourceLoader::removeCachedResource(WebCore::CachedResource&) + 257 (./loader/cache/CachedResourceHandle.cpp:55)
26  com.apple.WebCore             	0x7fff5d93cc3f WebCore::CachedResource::~CachedResource() + 47 (./loader/cache/CachedResource.cpp:178)
27  com.apple.WebCore             	0x7fff5ea5455e WebCore::CachedResource::~CachedResource() + 14 (./loader/cache/CachedResource.cpp:165)
Comment 1 Antti Koivisto 2019-02-07 01:07:25 PST 
<rdar://problem/42023295>
Comment 2 Antti Koivisto 2019-02-07 02:35:12 PST 
Created attachment 361387 [details]
patch
Comment 3 WebKit Commit Bot 2019-02-07 08:07:09 PST 
Comment on attachment 361387 [details]
patch

Clearing flags on attachment: 361387

Committed r241121: <https://trac.webkit.org/changeset/241121>
Comment 4 WebKit Commit Bot 2019-02-07 08:07:11 PST 
All reviewed patches have been landed.  Closing bug.