Bug 19434

Summary: speed up SunSpider by avoiding some string boxing
Product: WebKit Reporter: Darin Adler <darin>
Component: JavaScriptCoreAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Attachments:
Description Flags
patch
none
patch for part 1 (breaking up as per Maciej's request)
none
patch
none
patch mjs: review+

Darin Adler
Reported 2008-06-08 09:30:42 PDT
I have some speedups for SunSpider that total a bit over 1%.
Attachments
patch (48.85 KB, patch)
2008-06-08 09:31 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
patch for part 1 (breaking up as per Maciej's request) (16.94 KB, patch)
2008-06-11 14:47 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
patch (23.04 KB, patch)
2008-06-11 15:13 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
patch (23.16 KB, patch)
2008-06-11 15:22 PDT, Darin Adler 		mjs: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2008-06-08 09:31:03 PDT
Created attachment 21573 [details] patch
Maciej Stachowiak
Comment 2 2008-06-11 12:53:01 PDT
Any chance of breaking this up into the logically separate changes?
Darin Adler
Comment 3 2008-06-11 12:55:47 PDT
Sure, I'll do that now.
Darin Adler
Comment 4 2008-06-11 14:47:08 PDT
Created attachment 21645 [details] patch for part 1 (breaking up as per Maciej's request)
Maciej Stachowiak
Comment 5 2008-06-11 15:02:16 PDT
Comment on attachment 21645 [details] patch for part 1 (breaking up as per Maciej's request) r=me
Darin Adler
Comment 6 2008-06-11 15:02:47 PDT
Comment on attachment 21645 [details] patch for part 1 (breaking up as per Maciej's request) Landed this as r34499.
Darin Adler
Comment 7 2008-06-11 15:13:13 PDT
Created attachment 21646 [details] patch
Darin Adler
Comment 8 2008-06-11 15:22:44 PDT
Created attachment 21648 [details] patch
Maciej Stachowiak
Comment 9 2008-06-12 11:42:45 PDT
Comment on attachment 21648 [details] patch r=me It would be great to avoid the boxing for methods too, as discussed previously.
Darin Adler
Comment 10 2008-06-12 21:55:18 PDT
Committed revision 34518.
Note You need to log in before you can comment on or make changes to this bug.