Bug 194333

Summary:

RELEASE_ASSERT(!m_document.isResolvingTreeStyle()) in com.apple.WebKit.WebContent at WebCore: WebCore::StyleResolver::~StyleResolver

Product:

WebKit

Reporter:

Antti Koivisto <koivisto>

Component:

CSS

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, ddkilzer, ggaren, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=193488
https://bugs.webkit.org/show_bug.cgi?id=194335

Attachments:

Description	Flags
patch	none
patch	none

Antti Koivisto

Reported 2019-02-06 01:10:04 PST

Hitting a release assert: Thread 0 name: Dispatch queue: com.apple.main-thread Thread 0 Crashed ↩: 0 WebCore 0x00000001a0245d08 WTFCrashWithInfo(int, char const*, char const*, int) + 20 1 WebCore 0x00000001a0ef3178 WebCore::StyleResolver::~StyleResolver() + 796 (Assertions.h:578) 2 WebCore 0x00000001a1904074 WebCore::Style::Scope::scheduleUpdate(WebCore::Style::Scope::UpdateType) + 168 (memory:2321) 3 WebCore 0x00000001a10107a4 WebCore::ExtensionStyleSheets::addDisplayNoneSelector(WTF::String const&, WTF::String const&, unsigned int) + 348 (ExtensionStyleSheets.cpp:172) 4 WebCore 0x00000001a0e11f20 WebCore::ContentExtensions::ContentExtensionsBackend::processContentExtensionRulesForLoad(WTF::URL const&, WebCore::ResourceType, WebCore::DocumentLoader&) + 872 (ContentExtensionsBackend.cpp:190) 5 WebCore 0x00000001a14176e4 WebCore::CachedResourceLoader::requestResource(WebCore::CachedResource::Type, WebCore::CachedResourceRequest&&, WebCore::CachedResourceLoader::ForPreload, WebCore::CachedResourceLoader::DeferOption) + 880 (CachedResourceLoader.cpp:814) 6 WebCore 0x00000001a1416f68 WebCore::CachedResourceLoader::requestImage(WebCore::CachedResourceRequest&&) + 268 (CachedResourceLoader.cpp:213) 7 WebCore 0x00000001a0e98d10 WebCore::CSSImageValue::loadImage(WebCore::CachedResourceLoader&, WebCore::ResourceLoaderOptions const&) + 492 (CSSImageValue.cpp:78) 8 WebCore 0x00000001a18a8884 WebCore::StyleCachedImage::load(WebCore::CachedResourceLoader&, WebCore::ResourceLoaderOptions const&) + 80 (StyleCachedImage.cpp:91) 9 WebCore 0x00000001a18ffc74 WebCore::Style::loadPendingImage(WebCore::Document&, WebCore::StyleImage const*, WebCore::Element const*, WebCore::Style::LoadPolicy) + 460 (StylePendingResources.cpp:62) 10 WebCore 0x00000001a18ff930 WebCore::Style::loadPendingResources(WebCore::RenderStyle&, WebCore::Document&, WebCore::Element const*) + 64 (StylePendingResources.cpp:68) 11 WebCore 0x00000001a14e9484 WebCore::ImplicitAnimation::reset(WebCore::RenderStyle const&, WebCore::CompositeAnimation&) + 112 (ImplicitAnimation.cpp:206) 12 WebCore 0x00000001a14e9350 WebCore::ImplicitAnimation::animate(WebCore::CompositeAnimation&, WebCore::RenderStyle const&, std::__1::unique_ptr<WebCore::RenderStyle, std::__1::default_delete<WebCore::RenderStyle> >&, bool&) + 88 (ImplicitAnimation.cpp:75) 13 WebCore 0x00000001a14d3724 WebCore::CompositeAnimation::animate(WebCore::Element&, WebCore::RenderStyle const*, WebCore::RenderStyle const&) + 252 (CompositeAnimation.cpp:300) 14 WebCore 0x00000001a14d359c WebCore::CSSAnimationController::updateAnimations(WebCore::Element&, WebCore::RenderStyle const&, WebCore::RenderStyle const*) + 220 (CSSAnimationController.cpp:633) 15 WebCore 0x00000001a1906aac WebCore::Style::TreeResolver::createAnimatedElementUpdate(std::__1::unique_ptr<WebCore::RenderStyle, std::__1::default_delete<WebCore::RenderStyle> >, WebCore::Element&, WebCore::Style::Change) + 416 (StyleTreeResolver.cpp:312) 16 WebCore 0x00000001a19065dc WebCore::Style::TreeResolver::resolveElement(WebCore::Element&) + 344 (StyleTreeResolver.cpp:208) 17 WebCore 0x00000001a19073dc WebCore::Style::TreeResolver::resolveComposedTree() + 1204 (StyleTreeResolver.cpp:493) 18 WebCore 0x00000001a19080cc WebCore::Style::TreeResolver::resolve() + 720 (StyleTreeResolver.cpp:551) 19 WebCore 0x00000001a0fbcee8 WebCore::Document::resolveStyle(WebCore::Document::ResolveStyleType) + 920 (Document.cpp:1935) 20 WebCore 0x00000001a0fbd924 WebCore::Document::updateStyleIfNeeded() + 436 (Document.cpp:2064) 21 WebCore 0x00000001a0279e2c WebCore::Timer::fired() + 32 (Function.h:56) 22 WebCore 0x00000001a15388c8 WebCore::ThreadTimers::sharedTimerFiredInternal() + 196 (ThreadTimers.cpp:129) 23 WebCore 0x00000001a1522308 WebCore::MainThreadSharedTimer::fired() + 32 (Function.h:56) 24 WebCore 0x00000001a1557ba8 WebCore::timerFired(__CFRunLoopTimer*, void*) + 32 (MainThreadSharedTimerCF.cpp:74) 25 CoreFoundation 0x0000000196f0cf4c __CFRUNLOOP_IS_CALLING_OUT_TO_A_TIMER_CALLBACK_FUNCTION__ + 32 (CFRunLoop.c:1830) 26 CoreFoundation 0x0000000196f0cc78 __CFRunLoopDoTimer + 900 (CFRunLoop.c:2417) 27 CoreFoundation 0x0000000196f0c45c __CFRunLoopDoTimers + 252 (CFRunLoop.c:2564) 28 CoreFoundation 0x0000000196f07128 __CFRunLoopRun + 1816 (CFRunLoop.c:0) 29 CoreFoundation 0x0000000196f066f0 CFRunLoopRunSpecific + 452 (CFRunLoop.c:3247) 30 Foundation 0x00000001978e559c -[NSRunLoop(NSRunLoop) runMode:beforeDate:] + 304 (NSRunLoop.m:367) 31 Foundation 0x0000000197921eb0 -[NSRunLoop(NSRunLoop) run] + 92 (NSRunLoop.m:389) 32 libxpc.dylib 0x0000000196bca864 _xpc_objc_main + 520 (main.m:173) 33 libxpc.dylib 0x0000000196bcd2b8 xpc_main + 180 (init.c:1471) 34 com.apple.WebKit.WebContent 0x000000010433b71c WebKit::XPCServiceMain(int, char const**) + 396 (XPCServiceMain.mm:157) 35 com.apple.WebKit.WebContent 0x000000010433b8e4 main + 16 (XPCServiceMain.mm:165) 36 libdyld.dylib 0x00000001969c52d4 start + 4

Attachments
patch (4.98 KB, patch) 2019-02-06 05:16 PST, Antti Koivisto	no flags	Details Formatted Diff Diff
patch (5.06 KB, patch) 2019-02-06 06:22 PST, Antti Koivisto	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Antti Koivisto

Comment 1 2019-02-06 01:10:38 PST

<rdar://problem/47822929>

Antti Koivisto

Comment 2 2019-02-06 01:11:27 PST

This is the assert added in bug 193488

Antti Koivisto

Comment 3 2019-02-06 05:16:10 PST

Created attachment 361291 [details] patch

Antti Koivisto

Comment 4 2019-02-06 06:22:34 PST

Created attachment 361293 [details] patch

alan

Comment 5 2019-02-06 07:17:35 PST

Comment on attachment 361293 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=361293&action=review > Source/WebCore/ChangeLog:10 > + the legacy animation code triggering a resource load. gross

WebKit Commit Bot

Comment 6 2019-02-06 07:44:34 PST

Comment on attachment 361293 [details] patch Clearing flags on attachment: 361293 Committed r241018: <https://trac.webkit.org/changeset/241018>

WebKit Commit Bot

Comment 7 2019-02-06 07:44:36 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.