| Summary: | [LFC][IFC] Move line layout code to a dedicated file | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | zalan <zalan> | ||||||||
| Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | bfulgham, commit-queue, koivisto, simon.fraser, webkit-bug-importer, zalan | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
zalan
2019-02-05 20:37:31 PST
Created attachment 361271 [details]
Patch
Created attachment 361274 [details]
Patch
Comment on attachment 361274 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=361274&action=review > Source/WebCore/Sources.txt:1346 > +layout/inlineformatting/InlineLineLayout.cpp Since you are keeping LineLayout in InlineFormattingContext namespace you might also consider longer 'InlineFormattingContextLineLayout.cpp'. Or just LineLayout.cpp, especially if the plan is to move it outside of the namespace. > Source/WebCore/layout/inlineformatting/InlineFormattingContext.h:61 > + class Line { > + public: > + void init(const LayoutPoint& topLeft, LayoutUnit availableWidth, LayoutUnit minimalHeight); > + void close(); LineLayout::Line seems like a line layout internal thing so, maybe you can also move its definition to the new cpp file. You can forward declare a nested class (class Line;) here and define it later class LineLayout::Line { public: ... The same pattern might work for the LineLayout type itself too. Created attachment 361295 [details]
Patch
Comment on attachment 361295 [details] Patch Clearing flags on attachment: 361295 Committed r241023: <https://trac.webkit.org/changeset/241023> All reviewed patches have been landed. Closing bug. |