Bug 194328 – [LFC][IFC] Move line layout code to a dedicated file

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[zalan]

ssia

[zalan]

Created attachment 361271 [details]
Patch

[zalan]

Created attachment 361274 [details]
Patch

[Antti Koivisto]

Comment on attachment 361274 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=361274&action=review

> Source/WebCore/Sources.txt:1346
> +layout/inlineformatting/InlineLineLayout.cpp

Since you are keeping LineLayout in InlineFormattingContext namespace you might also consider longer 'InlineFormattingContextLineLayout.cpp'.

Or just LineLayout.cpp, especially if the plan is to move it outside of the namespace.

> Source/WebCore/layout/inlineformatting/InlineFormattingContext.h:61
> +        class Line {
> +        public:
> +            void init(const LayoutPoint& topLeft, LayoutUnit availableWidth, LayoutUnit minimalHeight);
> +            void close();

LineLayout::Line seems like a line layout internal thing so, maybe you can also move its definition to the new cpp file. You can forward declare a nested class (class Line;) here and define it later

class LineLayout::Line {
public:
   ...

The same pattern might work for the LineLayout type itself too.

[zalan]

Created attachment 361295 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 361295 [details]
Patch

Clearing flags on attachment: 361295

Committed r241023: <https://trac.webkit.org/changeset/241023>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/47851839>