Summary: | [ Mac WK1 ] Layout Test media/modern-media-controls/compact-media-controls/compact-media-controls-layout.html is a flaky text diff failure | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Shawn Roberts <sroberts> | ||||||||||
Component: | Media | Assignee: | Antoine Quint <graouts> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | aakash_jain, bfulgham, dbates, dino, eric.carlson, ews-watchlist, glenn, graouts, jer.noble, lforschler, philipj, ryanhaddad, sergio, tsavell, webkit-bot-watchers-bugzilla, webkit-bug-importer | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Shawn Roberts
2019-02-05 15:11:45 PST
Created attachment 362443 [details]
Patch
Comment on attachment 362443 [details] Patch Attachment 362443 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/11213240 New failing tests: js/dom/custom-constructors.html Created attachment 362472 [details]
Archive of layout-test-results from ews202 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews202 Port: win-future Platform: CYGWIN_NT-6.1-2.10.0-0.325-5-3-x86_64-64bit
Created attachment 362536 [details]
Update TestExpectations
Comment on attachment 362536 [details] Update TestExpectations Clearing flags on attachment: 362536 Committed r241835: <https://trac.webkit.org/changeset/241835> Additional repro steps: Searching on Trac I found the test was originally created in r228718 and was 100% failure. Test was modified 230895 and was a flaky failure. Continued to bisect to find exact regression point as follows. 242640 --iterations 1000 --exit-after-n-failures=5: 49 tests ran as expected, 5 didn't (946 didn't run) 230895 4 out of 1000 failures 230894 3 out of 1000 failures 230350 3 out of 1000 failures 230078 2 out of 1000 failures 230006 3 out of 1000 failures 230005 100% Failure 230004 100% Failure 230002 100% Failure 229998 100% Failure 229990 100% Failure 229974 100% Failure 229931 100% Failure 229931 100% Failure 229806 100% Failure 228718 100% Failure Correction, is not a regression. Code changed in 230006. Test was added in https://trac.webkit.org/changeset/228718/webkit and likely has been a flaky failure since then. Created attachment 393885 [details]
Patch
Committed r258656: <https://trac.webkit.org/changeset/258656> (In reply to Antoine Quint from comment #10) > Committed r258656: <https://trac.webkit.org/changeset/258656> media/modern-media-controls/compact-media-controls/compact-media-controls-layout.html seems to be consistently failing on iOS after r258656. History: https://results.webkit.org/?suite=layout-tests&test=media%2Fmodern-media-controls%2Fcompact-media-controls%2Fcompact-media-controls-layout.html The iOS-specific test expectations have been removed in r258688. |