Bug 194298

Summary: Move DFG nodes that clobberize() says will write(Heap) to the doesGC() list that returns true.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: fpizlo, keith_miller, msaboff, rmorisset, saam, simon.fraser, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch. saam: review+

Mark Lam
Reported 2019-02-05 12:39:58 PST
We do this for 2 reasons: 1. It's clearer when reading doesGC()'s code that these nodes will return true. 2. If things change in the future where clobberize() no longer reports these nodes as write(Heap), each node should be vetted first to make sure that it can never GC before being moved back to the doesGC() list that returns false.
Attachments
proposed patch. (8.61 KB, patch)
2019-02-05 12:51 PST, Mark Lam 		saam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-02-05 12:40:52 PST
<rdar://problem/47827555>
Radar WebKit Bug Importer
Comment 2 2019-02-05 12:41:28 PST
<rdar://problem/47827589>
Mark Lam
Comment 3 2019-02-05 12:51:11 PST
Created attachment 361210 [details] proposed patch.
Saam Barati
Comment 4 2019-02-05 12:55:13 PST
Comment on attachment 361210 [details] proposed patch. r=me
Mark Lam
Comment 5 2019-02-05 14:00:24 PST
Thanks for the review. Landed in r240991: <http://trac.webkit.org/r240991>.
Simon Fraser (smfr)
Comment 6 2019-02-11 21:35:20 PST
This bug title is really hard to parse.
Saam Barati
Comment 7 2019-04-15 19:12:51 PDT
(In reply to Simon Fraser (smfr) from comment #6) > This bug title is really hard to parse. It actually mostly makes sense in JSC lingo! But I agree, kinda hard to parse.
Note You need to log in before you can comment on or make changes to this bug.