Bug 194281

Summary:

[JSC] Shrink sizeof(UnlinkedCodeBlock)

Product:

WebKit

Reporter:

Yusuke Suzuki <ysuzuki>

Component:

New Bugs

Assignee:

Yusuke Suzuki <ysuzuki>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, cdumez, cmarcelo, dbates, ews-watchlist, keith_miller, mark.lam, msaboff, rniwa, saam, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews101 for mac-highsierra	none
Archive of layout-test-results from ews106 for mac-highsierra-wk2	none
Archive of layout-test-results from ews115 for mac-highsierra	none
Archive of layout-test-results from ews126 for ios-simulator-wk2	none
Patch	msaboff: review+

Yusuke Suzuki

Reported 2019-02-04 23:16:48 PST

[JSC] Shrink sizeof(UnlinkedCodeBlock)

Attachments
Patch (35.22 KB, patch) 2019-02-04 23:28 PST, Yusuke Suzuki	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews101 for mac-highsierra (2.85 MB, application/zip) 2019-02-05 00:49 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews106 for mac-highsierra-wk2 (3.44 MB, application/zip) 2019-02-05 01:15 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews115 for mac-highsierra (2.62 MB, application/zip) 2019-02-05 01:33 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews126 for ios-simulator-wk2 (20.73 MB, application/zip) 2019-02-05 01:52 PST, EWS Watchlist	no flags	Details
Patch (31.60 KB, patch) 2019-02-05 01:59 PST, Yusuke Suzuki	msaboff: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Yusuke Suzuki

Comment 1 2019-02-04 23:28:06 PST

Created attachment 361163 [details] Patch

EWS Watchlist

Comment 2 2019-02-05 00:49:07 PST

Comment on attachment 361163 [details] Patch Attachment 361163 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/11036615 New failing tests: inspector/unit-tests/objectStore/deleteObject.html imported/w3c/web-platform-tests/fetch/api/abort/general.any.html inspector/unit-tests/objectStore/delete.html imported/w3c/web-platform-tests/fetch/api/abort/keepalive.html inspector/audit/basic.html imported/w3c/web-platform-tests/fetch/api/abort/general.any.worker.html media/airplay-allows-buffering.html

EWS Watchlist

Comment 3 2019-02-05 00:49:08 PST

Created attachment 361171 [details] Archive of layout-test-results from ews101 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-highsierra Platform: Mac OS X 10.13.6

Yusuke Suzuki

Comment 4 2019-02-05 00:51:08 PST

(In reply to Build Bot from comment #2) > Comment on attachment 361163 [details] > Patch > > Attachment 361163 [details] did not pass mac-ews (mac): > Output: https://webkit-queues.webkit.org/results/11036615 > > New failing tests: > inspector/unit-tests/objectStore/deleteObject.html > imported/w3c/web-platform-tests/fetch/api/abort/general.any.html > inspector/unit-tests/objectStore/delete.html > imported/w3c/web-platform-tests/fetch/api/abort/keepalive.html > inspector/audit/basic.html > imported/w3c/web-platform-tests/fetch/api/abort/general.any.worker.html > media/airplay-allows-buffering.html Look into it.

EWS Watchlist

Comment 5 2019-02-05 01:14:59 PST

Comment on attachment 361163 [details] Patch Attachment 361163 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/11036689 New failing tests: http/tests/paymentrequest/payment-request-abort-method.https.html imported/w3c/web-platform-tests/fetch/api/abort/general.any.html inspector/unit-tests/objectStore/delete.html media/airplay-allows-buffering.html media/audio-controls-timeline-in-media-document.html http/tests/workers/service/serviceworkerclients-get.https.html imported/w3c/web-platform-tests/payment-request/payment-request-canmakepayment-method-protection.https.html imported/w3c/web-platform-tests/fetch/api/abort/keepalive.html http/wpt/service-workers/fetchEvent.https.html inspector/audit/basic.html imported/w3c/web-platform-tests/fetch/api/abort/general.any.worker.html inspector/unit-tests/objectStore/deleteObject.html

EWS Watchlist

Comment 6 2019-02-05 01:15:01 PST

Created attachment 361174 [details] Archive of layout-test-results from ews106 for mac-highsierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 7 2019-02-05 01:33:32 PST

Comment on attachment 361163 [details] Patch Attachment 361163 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/11036697 New failing tests: inspector/unit-tests/objectStore/deleteObject.html imported/w3c/web-platform-tests/fetch/api/abort/general.any.html inspector/unit-tests/objectStore/delete.html imported/w3c/web-platform-tests/fetch/api/abort/keepalive.html inspector/audit/basic.html imported/w3c/web-platform-tests/fetch/api/abort/general.any.worker.html media/airplay-allows-buffering.html

EWS Watchlist

Comment 8 2019-02-05 01:33:34 PST

Created attachment 361175 [details] Archive of layout-test-results from ews115 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-highsierra Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 9 2019-02-05 01:52:05 PST

Comment on attachment 361163 [details] Patch Attachment 361163 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/11036788 New failing tests: http/tests/paymentrequest/payment-request-abort-method.https.html imported/w3c/web-platform-tests/fetch/api/abort/general.any.html imported/w3c/web-platform-tests/payment-request/payment-request-canmakepayment-method-protection.https.html imported/w3c/web-platform-tests/fetch/api/abort/keepalive.html http/wpt/service-workers/fetchEvent.https.html fast/forms/datalist/datalist-show-hide.html http/tests/workers/service/serviceworkerclients-get.https.html

EWS Watchlist

Comment 10 2019-02-05 01:52:07 PST

Created attachment 361177 [details] Archive of layout-test-results from ews126 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6

Yusuke Suzuki

Comment 11 2019-02-05 01:59:16 PST

Created attachment 361178 [details] Patch

Michael Saboff

Comment 12 2019-02-05 10:24:39 PST

Comment on attachment 361178 [details] Patch r=me

Yusuke Suzuki

Comment 13 2019-02-05 10:28:42 PST

Committed r240981: <https://trac.webkit.org/changeset/240981>

Radar WebKit Bug Importer

Comment 14 2019-02-05 10:30:17 PST

<rdar://problem/47822467>

Note You need to log in before you can comment on or make changes to this bug.