Bug 194254 – Web Inspector: REGRESSION (r240947): Resources tab: can't select main frame after refreshing page

• Component: Web Inspector
• Status: RESOLVED FIXED

[Matt Baker]

Summary:
Can't select main frame after refreshing page.

Steps to Reproduce:
1. Inspect webkit.org
2. Open Resource tab
3. In the sidebar, select a child of the main resource
4. Reload page
5. The child should be re-selected after reload
6. Try to select the main resource using the mouse
  => Cannot click to select

Note:
Hitting the up arrow key to select the main resource from the child works fine.

[Radar WebKit Bug Importer]

<rdar://problem/47805023>

[Matt Baker]

Regressed in https://trac.webkit.org/changeset/240947.

[Matt Baker]

Created attachment 361142 [details]
Patch

[Matt Baker]

(In reply to Matt Baker from comment #2)
> Regressed in https://trac.webkit.org/changeset/240947.

This patch actually just allowed the bug to manifest. It was a defect lurking in TreeOutline from before this change was made.

[Devin Rousso]

Comment on attachment 361142 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=361142&action=review

r-, can you write some sort of test for this?  I think we've long passed the point where we need regression tests for our common UI classes.

> Source/WebInspectorUI/UserInterface/Views/TreeOutline.js:825
> +                const omitFocus = true;

This doesn't seem right.  If we try to select a `WI.TreeElement` via `_handleMouseDown`, we'd never focus the parent.  Either provide a justification for this, or maybe be a bit more "limiting" (e.g. only `omitFocus` when there is more than one `selectedItems`).

[Matt Baker]

Comment on attachment 361142 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=361142&action=review

>> Source/WebInspectorUI/UserInterface/Views/TreeOutline.js:825
>> +                const omitFocus = true;
> 
> This doesn't seem right.  If we try to select a `WI.TreeElement` via `_handleMouseDown`, we'd never focus the parent.  Either provide a justification for this, or maybe be a bit more "limiting" (e.g. only `omitFocus` when there is more than one `selectedItems`).

Actually that's not the case. The tree receives the focus by virtue of being clicked; the awful `omitFocus` flag is only for forcing the focus when selecting elements programmatically.

[Matt Baker]

(In reply to Devin Rousso from comment #5)
> Comment on attachment 361142 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=361142&action=review
> 
> r-, can you write some sort of test for this?  I think we've long passed the
> point where we need regression tests for our common UI classes.

Added a comment to https://bugs.webkit.org/show_bug.cgi?id=192044.

[Devin Rousso]

Comment on attachment 361142 [details]
Patch

rs=me, please don't forget to write tests :)

[WebKit Commit Bot]

Comment on attachment 361142 [details]
Patch

Clearing flags on attachment: 361142

Committed r240997: <https://trac.webkit.org/changeset/240997>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.