Bug 194253

Summary: [ Mac WK2 iOS Debug ] Layout Test scrollingcoordinator/scrolling-tree/fixed-inside-frame.html is flaky failure
Product: WebKit Reporter: Shawn Roberts <sroberts>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED CONFIGURATION CHANGED    
Severity: Normal CC: koivisto, lforschler, simon.fraser, tsavell, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Update TestExpectations none

Description Shawn Roberts 2019-02-04 16:28:23 PST
The following layout test is flaky on Mac WK2

scrollingcoordinator/scrolling-tree/fixed-inside-frame.html

Probable cause:

Test starts to be a flaky failure in build https://trac.webkit.org/changeset/240713/webkit

Test was modified in 240548

Tests conducted from 240548 to build 240712 result in 100% failure

Reproduced with:

run-webkit-tests --root t240713 scrollingcoordinator/scrolling-tree/fixed-inside-frame.html --iterations 50 -f

Flakiness Dashboard:

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=scrollingcoordinator%2Fscrolling-tree%2Ffixed-inside-frame.html

Diff:

--- /Volumes/Data/slave/mojave-release-tests-wk2/build/layout-test-results/scrollingcoordinator/scrolling-tree/fixed-inside-frame-expected.txt
+++ /Volumes/Data/slave/mojave-release-tests-wk2/build/layout-test-results/scrollingcoordinator/scrolling-tree/fixed-inside-frame-actual.txt
@@ -32,15 +32,15 @@
             (vertical scrollbar mode 0)
             (has enabled vertical scrollbar 1))
           (visual viewport enabled 1)
-          (layout viewport at (0,120) size 465x400)
+          (layout viewport at (0,0) size 465x400)
           (min layout viewport origin (0,0))
           (max layout viewport origin (0,616))
           (behavior for fixed 0)
           (children 1
             (Fixed node
               (anchor edges: AnchorEdgeLeft AnchorEdgeTop)
-              (viewport rect at last layout at (0,120) size 465x400)
-              (layer position at last layout (10,130))
+              (viewport rect at last layout at (0,0) size 465x400)
+              (layer position at last layout (10,10))
             )
           )
         )
@@ -70,7 +70,6 @@
                   (bounds 465.00 400.00)
                   (children 1
                     (GraphicsLayer
-                      (position 0.00 -120.00)
                       (anchor 0.00 0.00)
                       (children 1
                         (GraphicsLayer
@@ -82,7 +81,7 @@
                               (drawsContent 1)
                               (children 1
                                 (GraphicsLayer
-                                  (position 10.00 130.00)
+                                  (position 10.00 10.00)
                                   (bounds 455.00 100.00)
                                   (contentsOpaque 1)
                                   (drawsContent 1)
Comment 1 Radar WebKit Bug Importer 2019-02-05 10:00:47 PST
<rdar://problem/47821372>
Comment 2 Shawn Roberts 2019-02-19 14:56:17 PST
Created attachment 362439 [details]
Patch
Comment 3 Shawn Roberts 2019-02-20 13:47:23 PST
Created attachment 362534 [details]
Update TestExpectations
Comment 4 Truitt Savell 2019-02-20 13:49:57 PST
Comment on attachment 362534 [details]
Update TestExpectations

Clearing flags on attachment: 362534

Committed r241834: <https://trac.webkit.org/changeset/241834>
Comment 5 Shawn Roberts 2019-03-08 15:23:29 PST
Additional repro steps:


T240944 12/50 Failure
T240746 Failure 2/50
T240722 Failure 8/50
T240718 Failure 7/50
T240715 Failure 6/60
T240714 Failure 8/50
T240713 Failure 9/50

T240712 100% failure
T240701 100% failure
T240656 100% failure
T240548 100% failure
Comment 6 Shawn Roberts 2019-04-03 13:33:20 PDT
Correction, is not a regression. Code was changed in 240713

Test was added in https://trac.webkit.org/changeset/240548/webkit

Test has likely been flaky since it was introduced.
Comment 7 Shawn Roberts 2019-05-24 10:48:14 PDT
Removed expectations in https://trac.webkit.org/changeset/245747/webkit

Unable to reproduce flakiness locally, and testers have not seen any failures recently. 

Closing bug/radar