Bug 194215

Summary: Rename GraphicsLayer and PlatformCALayer scrolling layer type enum values to be less ambiguous
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: ScrollingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, fred.wang, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
patch
fred.wang: review+
patch none

Antti Koivisto
Reported 2019-02-04 01:01:23 PST
Reduce use of ambiguous "scroll layer"
Attachments
patch (11.14 KB, patch)
2019-02-04 01:08 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
patch (11.63 KB, patch)
2019-02-04 01:13 PST, Antti Koivisto 		fred.wang: review+
DetailsFormatted DiffDiff
patch (12.58 KB, patch)
2019-02-04 04:09 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2019-02-04 01:08:59 PST
Created attachment 361045 [details] patch
Antti Koivisto
Comment 2 2019-02-04 01:13:19 PST
Created attachment 361046 [details] patch
Frédéric Wang (:fredw)
Comment 3 2019-02-04 02:23:27 PST
Comment on attachment 361046 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=361046&action=review > Source/WebCore/ChangeLog:10 > + I guess there should be a "no new tests" line with "behavior unchanged" or "already covered by existing tests" (depending on whether the change affects dumped text in existing tests).
Antti Koivisto
Comment 4 2019-02-04 04:09:58 PST
Created attachment 361051 [details] patch
WebKit Commit Bot
Comment 5 2019-02-04 04:48:26 PST
Comment on attachment 361051 [details] patch Clearing flags on attachment: 361051 Committed r240918: <https://trac.webkit.org/changeset/240918>
WebKit Commit Bot
Comment 6 2019-02-04 04:48:28 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2019-02-04 04:49:27 PST
<rdar://problem/47783902>
Note You need to log in before you can comment on or make changes to this bug.