Bug 194201 – [GTK] Allow pinch zoom on touchpad

• Component: WebKitGTK
• Status: RESOLVED FIXED

[Alice Mikhaylenko]

A follow-up to bug 193919, another touchpad gesture missing in GTK port.

[Alice Mikhaylenko]

Created attachment 361011 [details]
Patch

[EWS Watchlist]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[Michael Catanzaro]

Comment on attachment 361011 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=361011&action=review

Does this depend on the other patch? If not, you can request cq? for commit-queue.

> Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp:1202
> +    if (event->type == GDK_TOUCHPAD_PINCH) {
> +        WebKitWebViewBase* webViewBase = WEBKIT_WEB_VIEW_BASE(widget);
> +        GestureController& controller = webkitWebViewBaseGestureController(webViewBase);
> +        controller.handleEvent(event);
> +    }

Style: just do it on one line:

if (event->type == GDK_TOUCHPAD_PINCH)
    webkitWebViewBaseGestureController(WEBKIT_WEB_VIEW_BASE(widget)).handleEvent(event);

In C it would be too hard to read if we don't use multiple lines, but this is C++. :)

[Alice Mikhaylenko]

Created attachment 361023 [details]
Patch

[Alice Mikhaylenko]

> Does this depend on the other patch? 
No

> just do it on one line:
Ok

[Alice Mikhaylenko]

Created attachment 361028 [details]
Patch

[Alice Mikhaylenko]

Created attachment 361030 [details]
Patch

[Alice Mikhaylenko]

I've added #if HAVE(GTK_GESTURES) checks around the added code.

[Michael Catanzaro]

Comment on attachment 361030 [details]
Patch

Remember to request cq? for commit queue when it's ready to land!

[Alice Mikhaylenko]

> Remember to request cq? for commit queue when it's ready to land!

Done

[WebKit Commit Bot]

Comment on attachment 361030 [details]
Patch

Clearing flags on attachment: 361030

Committed r240922: <https://trac.webkit.org/changeset/240922>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.