Bug 194199

Summary: PageOverlayController's layers should be created lazily
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, ews-watchlist, rniwa, simon.fraser, sroberts, thorton, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 194198    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews104 for mac-highsierra-wk2
none
Patch none

Simon Fraser (smfr)
Reported 2019-02-02 19:52:59 PST
PageOverlayController's layers should be created lazily
Attachments
Patch (34.07 KB, patch)
2019-02-02 20:06 PST, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews104 for mac-highsierra-wk2 (2.56 MB, application/zip)
2019-02-03 19:18 PST, EWS Watchlist 		no flags
Details
Patch (41.54 KB, patch)
2019-02-04 11:41 PST, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2019-02-02 20:06:13 PST
Created attachment 360992 [details] Patch
Simon Fraser (smfr)
Comment 2 2019-02-02 20:06:16 PST
<rdar://problem/46571593>
EWS Watchlist
Comment 3 2019-02-03 19:18:24 PST
Comment on attachment 360992 [details] Patch Attachment 360992 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/11020247 New failing tests: pageoverlay/overlay-remove-reinsert-view.html
EWS Watchlist
Comment 4 2019-02-03 19:18:26 PST
Created attachment 361035 [details] Archive of layout-test-results from ews104 for mac-highsierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6
Simon Fraser (smfr)
Comment 5 2019-02-04 11:41:01 PST
Created attachment 361080 [details] Patch
WebKit Commit Bot
Comment 6 2019-02-04 13:16:28 PST
Comment on attachment 361080 [details] Patch Clearing flags on attachment: 361080 Committed r240940: <https://trac.webkit.org/changeset/240940>
WebKit Commit Bot
Comment 7 2019-02-04 13:16:30 PST
All reviewed patches have been landed. Closing bug.
Benjamin Poulain
Comment 8 2019-02-04 14:22:00 PST
Wooooooot Thanks Simon!
Shawn Roberts
Comment 9 2019-02-04 16:58:10 PST
Looks like the pageoverlay layout tests there were re-enabled in this change are a flaky failure in iOS simulator. https://build.webkit.org/results/Apple%20iOS%2012%20Simulator%20Release%20WK2%20(Tests)/r240940%20(2410)/results.html
Simon Fraser (smfr)
Comment 10 2019-02-04 17:13:43 PST
I think it's fine to mark these as flakey on iOS. The macOS testing coverage is good enough.
Note You need to log in before you can comment on or make changes to this bug.