Bug 194170 – [ Mac WK2 ] Layout Test fast/repaint/placeholder-after-caps-lock-hidden.html is a flaky failure

• Component: Tools / Tests
• Status: REOPENED

[Shawn Roberts]

The following layout test is flaky on Mojave WK2

fast/repaint/placeholder-after-caps-lock-hidden.html

Probable cause:

Appears to be a flaky failure since build 238519

Reproducible with:

run-webkit-tests t240858 fast/repaint/placeholder-after-caps-lock-hidden.html --iterations 500 -f --exit-after-n-failures=1 --no-retry-failures

Flakiness Dashboard:

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=fast%2Frepaint%2Fplaceholder-after-caps-lock-hidden.html

Diff:

--- /Volumes/Data/slave/mojave-release-tests-wk2/build/layout-test-results/fast/repaint/placeholder-after-caps-lock-hidden-expected.txt
+++ /Volumes/Data/slave/mojave-release-tests-wk2/build/layout-test-results/fast/repaint/placeholder-after-caps-lock-hidden-actual.txt
@@ -2,6 +2,8 @@
 
 
 (repaint rects
+  (rect 31 50 22 22)
+  (rect 36 55 12 12)
   (rect 31 50 22 22)
   (rect 36 55 12 12)
   (rect 8 50 33 23)

[Radar WebKit Bug Importer]

<rdar://problem/48012771>

[Shawn Roberts]

Created attachment 362429 [details]
Update TestExpectations

[WebKit Commit Bot]

Comment on attachment 362429 [details]
Update TestExpectations

Rejecting attachment 362429 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 362429, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as [e-mail]...
Fetching: https://bugs.webkit.org/attachment.cgi?id=362429&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=194170&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Processing patch 362429 from bug 194170.
Fetching: https://bugs.webkit.org/attachment.cgi?id=362429
Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Parsed 2 diffs from patch file(s).
patching file LayoutTests/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file LayoutTests/platform/mac-wk2/TestExpectations
Hunk #2 FAILED at 910.
1 out of 2 hunks FAILED -- saving rejects to file LayoutTests/platform/mac-wk2/TestExpectations.rej

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: https://webkit-queues.webkit.org/results/11219515

[Shawn Roberts]

Created attachment 362520 [details]
Update TestExpectations

[Truitt Savell]

Comment on attachment 362520 [details]
Update TestExpectations

Clearing flags on attachment: 362520

Committed r241827: <https://trac.webkit.org/changeset/241827>

[Truitt Savell]

All reviewed patches have been landed.  Closing bug.

[Truitt Savell]

reopen

[Shawn Roberts]

Additional repro steps:

Searching on Trac I found the test was created r238519, had several changes done to it in revisions 239277 and 238520. However remains a flaky failure and is a 100% failure on any revision before it. 

242640 3 out of 500 failed
239277 4 out of 500 failed
238520 3 out of 500 failed
238519 2 out of 500 failed

238518 100% failure

[Shawn Roberts]

Correction, is not a regression. Test was added in https://trac.webkit.org/changeset/238519/webkit