Bug 194145

Summary: [JSC] Remove cellJSValueOOBSpace
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 193606    
Attachments:
Description Flags
Patch mark.lam: review+

Yusuke Suzuki
Reported 2019-01-31 23:32:43 PST
[JSC] Remove cellJSValueOOBSpace
Attachments
Patch (3.60 KB, patch)
2019-01-31 23:34 PST, Yusuke Suzuki 		mark.lam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2019-01-31 23:34:06 PST
Created attachment 360841 [details] Patch
Mark Lam
Comment 2 2019-02-01 10:02:11 PST
Comment on attachment 360841 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=360841&action=review > Source/JavaScriptCore/ChangeLog:3 > + [JSC] Remove cellJSValueOOBSpace Can you provide some context on why this is needed and appropriate?
Mark Lam
Comment 3 2019-02-01 10:55:23 PST
Comment on attachment 360841 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=360841&action=review >> Source/JavaScriptCore/ChangeLog:3 >> + [JSC] Remove cellJSValueOOBSpace > > Can you provide some context on why this is needed and appropriate? Spoke to Yusuke offline. This subspace does not currently add any value. So, we're removing it.
Yusuke Suzuki
Comment 4 2019-02-01 11:00:00 PST
Committed r240859: <https://trac.webkit.org/changeset/240859>
Radar WebKit Bug Importer
Comment 5 2019-02-01 11:01:01 PST
<rdar://problem/47741849>
Saam Barati
Comment 6 2019-02-01 11:17:50 PST
Can we go back to our previous naming of these subspaces too? DangerousBits doesn't make much sense anymore given we're ripping this out.
Yusuke Suzuki
Comment 7 2019-02-01 11:18:59 PST
(In reply to Saam Barati from comment #6) > Can we go back to our previous naming of these subspaces too? DangerousBits > doesn't make much sense anymore given we're ripping this out. Nice catch! I'll do that soon.
Yusuke Suzuki
Comment 8 2019-02-01 11:22:00 PST
(In reply to Yusuke Suzuki from comment #7) > (In reply to Saam Barati from comment #6) > > Can we go back to our previous naming of these subspaces too? DangerousBits > > doesn't make much sense anymore given we're ripping this out. > > Nice catch! I'll do that soon. The previous name was cellSpace.
Yusuke Suzuki
Comment 9 2019-02-01 11:33:26 PST
Committed r240860: <https://trac.webkit.org/changeset/240860>
Note You need to log in before you can comment on or make changes to this bug.