Bug 194103 – [SOUP] Improve use of SoupCookiePersistentStorageType

• Component: WebKitGTK
• Status: RESOLVED FIXED

[Michael Catanzaro]

Improve use of SoupCookiePersistentStorageType. Turn it into an enum class, and stop casting it to and from uint32_t.

[Michael Catanzaro]

Created attachment 360747 [details]
Patch

[EWS Watchlist]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[Carlos Garcia Campos]

Comment on attachment 360747 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=360747&action=review

> Source/WebKit/Shared/soup/SoupCookiePersistentStorageType.h:30
> +enum class SoupCookiePersistentStorageType : bool {

why bool?

[Michael Catanzaro]

Comment on attachment 360747 [details]
Patch

Because there's only two possible values. It's an implementation detail -- we can change it whenever we want -- but there's another bool-typed enum in NetworkProcess messages so seemed good to match that.

Maybe I'll change it to uint8_t before landing so we'll never have to change it even in the unlikely case we add a new storage type; let's see if that works.

[Michael Catanzaro]

(In reply to Michael Catanzaro from comment #4)
> Maybe I'll change it to uint8_t before landing so we'll never have to change
> it even in the unlikely case we add a new storage type; let's see if that
> works.

Weird build errors. Let's just use int.

[Michael Catanzaro]

Even that causes strange failures. I'll land it as-is... bool is an OK type for a two-valued enum.

[WebKit Commit Bot]

Comment on attachment 360747 [details]
Patch

Clearing flags on attachment: 360747

Committed r240858: <https://trac.webkit.org/changeset/240858>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.