Bug 194069

Summary: [MSE][GStreamer] Remove if (m_playerPrivate) from MediaSourceClientGStreamerMSE
Product: WebKit Reporter: Alicia Boya García <aboya>
Component: WebKitGTKAssignee: Alicia Boya García <aboya>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, calvaris, commit-queue, mcatanzaro, webkit-bug-importer
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Alicia Boya García
Reported 2019-01-30 17:39:30 PST
m_playerPrivate is non-NULL since MediaSourceClientGStreamerMSE creation well until its destruction. The only case that could make a NULL m_playerPrivate is clearPlayerPrivate() but that method is not used anymore.
Attachments
Patch (6.34 KB, patch)
2019-01-30 17:40 PST, Alicia Boya García 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alicia Boya García
Comment 1 2019-01-30 17:40:32 PST
Created attachment 360658 [details] Patch
Michael Catanzaro
Comment 2 2019-01-30 21:14:26 PST
Comment on attachment 360658 [details] Patch I think you should also change m_playerPrivate from MediaPlayerPrivateGStreamerMSE* to MediaPlayerPrivateGStreamerMSE&.
WebKit Commit Bot
Comment 3 2019-01-31 06:52:50 PST
Comment on attachment 360658 [details] Patch Clearing flags on attachment: 360658 Committed r240783: <https://trac.webkit.org/changeset/240783>
WebKit Commit Bot
Comment 4 2019-01-31 06:52:52 PST
All reviewed patches have been landed. Closing bug.
Alicia Boya García
Comment 5 2019-01-31 08:05:13 PST
(In reply to Michael Catanzaro from comment #2) > Comment on attachment 360658 [details] > Patch > > I think you should also change m_playerPrivate from > MediaPlayerPrivateGStreamerMSE* to MediaPlayerPrivateGStreamerMSE&. I agree that's better in this case. https://bugs.webkit.org/show_bug.cgi?id=194091
Note You need to log in before you can comment on or make changes to this bug.