Bug 194059

Summary: [NSDragItem init] is unavailable
Product: WebKit Reporter: Keith Rollin <krollin>
Component: Tools / TestsAssignee: Keith Rollin <krollin>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, commit-queue, lforschler, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Keith Rollin
Reported 2019-01-30 16:10:17 PST
[NSDragItem init] is marked as NS_UNAVAILABLE. This affects DumpRenderTree and TestWebKitAPI, which both try to create an NSDragItem in a manner that invokes this method. Address this by using -initWithPasteboardWriter instead.
Attachments
Patch (3.09 KB, patch)
2019-01-30 16:17 PST, Keith Rollin 		no flags
DetailsFormatted DiffDiff
Patch (3.23 KB, patch)
2019-01-30 17:09 PST, Keith Rollin 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-01-30 16:10:47 PST
<rdar://problem/47685715>
Keith Rollin
Comment 2 2019-01-30 16:17:06 PST
Created attachment 360639 [details] Patch
Wenson Hsieh
Comment 3 2019-01-30 16:48:18 PST
Comment on attachment 360639 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=360639&action=review > Tools/DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:280 > + auto item = adoptNS([[NSDraggingItem alloc] initWithPasteboardWriter:(id<NSPasteboardWriting>)receiver.get()]); Nit - we generally prefer spaces between id and < for ObjC protocols like this. > Tools/TestWebKitAPI/mac/TestDraggingInfo.mm:118 > + auto item = adoptNS([[NSDraggingItem alloc] initWithPasteboardWriter:(id<NSPasteboardWriting>)receiver.get()]); It might be worth adding a FIXME here referencing https://bugs.webkit.org/show_bug.cgi?id=194060, too.
Keith Rollin
Comment 4 2019-01-30 17:09:02 PST
Created attachment 360653 [details] Patch
WebKit Commit Bot
Comment 5 2019-01-30 18:18:23 PST
Comment on attachment 360653 [details] Patch Clearing flags on attachment: 360653 Committed r240749: <https://trac.webkit.org/changeset/240749>
WebKit Commit Bot
Comment 6 2019-01-30 18:18:25 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.