Bug 194055

Summary:

WebCore::WHLSL::AST::Expression copy constructor needs to be be default, not delete

Product:

WebKit

Reporter:

Keith Rollin <krollin>

Component:

WebCore Misc.

Assignee:

Keith Rollin <krollin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, mmaxfield, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Keith Rollin

Reported 2019-01-30 15:41:22 PST

WebCore::WHLSL::AST::Expression has a deleted copy constructor. EnumerationMemberLiteral, a subclass, has a default copy constructor. Some compilers may complain that the latter's c'tor can't access the former's, because it doesn't exist. Fix this by marking Expression's c'tor as default.

Attachments
Patch (1.69 KB, patch) 2019-01-30 15:47 PST, Keith Rollin	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2019-01-30 15:41:38 PST

<rdar://problem/47684570>

Keith Rollin

Comment 2 2019-01-30 15:47:58 PST

Created attachment 360635 [details] Patch

WebKit Commit Bot

Comment 3 2019-01-31 14:11:37 PST

Comment on attachment 360635 [details] Patch Clearing flags on attachment: 360635 Committed r240816: <https://trac.webkit.org/changeset/240816>

WebKit Commit Bot

Comment 4 2019-01-31 14:11:39 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.