Bug 194049

Summary: Web Inspector: change style of device settings override popover content
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hi, inspector-bugzilla-changes, joepeck, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
joepeck: review+
[Image] After Patch is applied
none
[Image] After Patch is applied
none
Patch none

Devin Rousso
Reported 2019-01-30 14:33:43 PST
It doesn't really match the Settings tab right now, so we should change that.
Attachments
Patch (10.50 KB, patch)
2019-01-30 14:38 PST, Devin Rousso 		joepeck: review+
DetailsFormatted DiffDiff
[Image] After Patch is applied (10.50 KB, patch)
2019-01-30 14:38 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
[Image] After Patch is applied (70.35 KB, image/png)
2019-01-30 14:39 PST, Devin Rousso 		no flags
Details
Patch (10.53 KB, patch)
2019-01-30 14:44 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2019-01-30 14:38:36 PST
Created attachment 360621 [details] Patch
Devin Rousso
Comment 2 2019-01-30 14:38:48 PST
Created attachment 360622 [details] [Image] After Patch is applied
Devin Rousso
Comment 3 2019-01-30 14:39:00 PST
Created attachment 360623 [details] [Image] After Patch is applied
Joseph Pecoraro
Comment 4 2019-01-30 14:40:24 PST
Comment on attachment 360621 [details] Patch rs=me
Devin Rousso
Comment 5 2019-01-30 14:44:45 PST
Created attachment 360625 [details] Patch Minor start positioning fix for checkboxes vs select.
WebKit Commit Bot
Comment 6 2019-01-30 15:54:16 PST
Comment on attachment 360625 [details] Patch Clearing flags on attachment: 360625 Committed r240737: <https://trac.webkit.org/changeset/240737>
WebKit Commit Bot
Comment 7 2019-01-30 15:54:18 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2019-01-30 15:55:28 PST
<rdar://problem/47685167>
Note You need to log in before you can comment on or make changes to this bug.