Bug 194035

Summary: [macOS] Sandbox fails to compile on 10.12
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: WebKit Misc.Assignee: Per Arne Vollan <pvollan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, ddkilzer, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Per Arne Vollan
Reported 2019-01-30 12:55:25 PST
This was caused by <https://trac.webkit.org/changeset/239994>.
Attachments
Patch (1.89 KB, patch)
2019-01-30 12:59 PST, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Per Arne Vollan
Comment 1 2019-01-30 12:59:31 PST
rdar://problem/47651260
Per Arne Vollan
Comment 2 2019-01-30 12:59:53 PST
Created attachment 360605 [details] Patch
Brent Fulgham
Comment 3 2019-01-30 13:41:50 PST
Comment on attachment 360605 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=360605&action=review > Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:615 > +#endif It seems like this could be combined with the guard below it. But not worth changing.
Per Arne Vollan
Comment 4 2019-01-30 14:05:25 PST
(In reply to Brent Fulgham from comment #3) > Comment on attachment 360605 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=360605&action=review > > > Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:615 > > +#endif > > It seems like this could be combined with the guard below it. But not worth > changing. Thanks for reviewing, Brent!
WebKit Commit Bot
Comment 5 2019-01-30 15:11:22 PST
Comment on attachment 360605 [details] Patch Clearing flags on attachment: 360605 Committed r240733: <https://trac.webkit.org/changeset/240733>
WebKit Commit Bot
Comment 6 2019-01-30 15:11:23 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.