Bug 194017

Summary: [WPE] Bump font related dependencies to match the GTK+ port
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WPE WebKitAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aperez, bugs-noreply, clopez, commit-queue, ews-watchlist, webkit-bug-importer, zan
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 194022    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch for landing none

Carlos Garcia Campos
Reported 2019-01-30 06:18:53 PST
Use the same dependencies as the GTK+ port.
Attachments
Patch (7.02 KB, patch)
2019-01-30 06:20 PST, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Patch for landing (7.31 KB, patch)
2019-01-31 01:29 PST, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2019-01-30 06:20:48 PST
Created attachment 360575 [details] Patch
WebKit Commit Bot
Comment 2 2019-01-30 07:05:00 PST
Comment on attachment 360575 [details] Patch Clearing flags on attachment: 360575 Committed r240708: <https://trac.webkit.org/changeset/240708>
WebKit Commit Bot
Comment 3 2019-01-30 07:05:01 PST
All reviewed patches have been landed. Closing bug.
WebKit Commit Bot
Comment 4 2019-01-30 08:38:04 PST
Re-opened since this is blocked by bug 194022
Carlos Garcia Campos
Comment 5 2019-01-30 08:44:02 PST
I'm sorry about this, it built for me locally and I assumed it would build in the bots as well. It's a deps version bump after all, but it seems there was a reason why icu was not built in the jhbuild. I still don't understand why it fails to link in the bots, though.
Carlos Garcia Campos
Comment 6 2019-01-31 01:29:11 PST
Created attachment 360704 [details] Patch for landing
Carlos Garcia Campos
Comment 7 2019-01-31 01:55:11 PST
hmm, I'm not sure EWS will help here, since it probably requires a clean build. Let's land and watch the bots instead.
WebKit Commit Bot
Comment 8 2019-01-31 02:11:52 PST
Comment on attachment 360704 [details] Patch for landing Clearing flags on attachment: 360704 Committed r240774: <https://trac.webkit.org/changeset/240774>
WebKit Commit Bot
Comment 9 2019-01-31 02:11:53 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.