Bug 193985

Summary:

Make sure we have a frame before trying to access its loader

Product:

WebKit

Reporter:

Brent Fulgham <bfulgham>

Component:

WebCore Misc.

Assignee:

Brent Fulgham <bfulgham>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, bfulgham, cdumez, commit-queue, dbates, ddkilzer, ews-watchlist, japhet, rniwa, wilander

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Brent Fulgham

Reported 2019-01-29 14:58:01 PST

Early seeding of iOS 12.2 showed some nullptr dereferences in 'ResourceLoadObserver::logUserInteractionWithReducedTimeResolution'. Code inspection and review of the backtraces reveal that the code attempts to access the frame's loader, even if the frame is a nullptr. We check for null frames in other uses of the document frame member, so should do so here as well.

Attachments
Patch (2.09 KB, patch) 2019-01-29 15:16 PST, Brent Fulgham	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Brent Fulgham

Comment 1 2019-01-29 14:58:17 PST

<rdar://problem/47618239>

Brent Fulgham

Comment 2 2019-01-29 15:16:59 PST

Created attachment 360506 [details] Patch

John Wilander

Comment 3 2019-01-29 15:20:10 PST

Comment on attachment 360506 [details] Patch LGTM.

WebKit Commit Bot

Comment 4 2019-01-29 17:42:55 PST

Comment on attachment 360506 [details] Patch Clearing flags on attachment: 360506 Committed r240697: <https://trac.webkit.org/changeset/240697>

WebKit Commit Bot

Comment 5 2019-01-29 17:42:56 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.