Bug 193882

Summary: Make it easier for non-Apple ports to enable dark mode CSS support
Product: WebKit Reporter: Timothy Hatcher <timothy>
Component: CSSAssignee: Timothy Hatcher <timothy>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, commit-queue, megan_gardner, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Timothy Hatcher
Reported 2019-01-26 23:51:49 PST
At the contributors meeting last fall, other ports were interested in enabling support. This is pretty simple to do.
Attachments
Patch (14.11 KB, patch)
2019-01-27 00:01 PST, Timothy Hatcher 		no flags
DetailsFormatted DiffDiff
Patch (14.18 KB, patch)
2019-01-27 00:11 PST, Timothy Hatcher 		no flags
DetailsFormatted DiffDiff
Patch (18.47 KB, patch)
2019-01-27 00:36 PST, Timothy Hatcher 		no flags
DetailsFormatted DiffDiff
Patch (18.78 KB, patch)
2019-01-27 11:49 PST, Timothy Hatcher 		no flags
DetailsFormatted DiffDiff
Patch (19.08 KB, patch)
2019-01-27 12:36 PST, Timothy Hatcher 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Timothy Hatcher
Comment 1 2019-01-27 00:01:19 PST Comment hidden (obsolete)
Timothy Hatcher
Comment 2 2019-01-27 00:11:27 PST Comment hidden (obsolete)
Timothy Hatcher
Comment 3 2019-01-27 00:36:43 PST Comment hidden (obsolete)
Timothy Hatcher
Comment 4 2019-01-27 11:49:23 PST Comment hidden (obsolete)
Timothy Hatcher
Comment 5 2019-01-27 12:36:03 PST
Created attachment 360305 [details] Patch
Megan Gardner
Comment 6 2019-01-28 17:12:28 PST
Comment on attachment 360305 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=360305&action=review > Source/WebKit/WebProcess/WebPage/WebPage.cpp:4507 > + nit - extra line > Source/WebKitLegacy/mac/WebView/WebView.mm:5308 > I feel a little weird about this not have a default implementation/implementation on other platforms, but since it's wholly in the scope, I won't whine too loudly.
Timothy Hatcher
Comment 7 2019-01-28 17:24:39 PST
Comment on attachment 360305 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=360305&action=review >> Source/WebKit/WebProcess/WebPage/WebPage.cpp:4507 >> + > > nit - extra line This was just Xcode removing whitespace. >> Source/WebKitLegacy/mac/WebView/WebView.mm:5308 >> > > I feel a little weird about this not have a default implementation/implementation on other platforms, but since it's wholly in the scope, I won't whine too loudly. This was to keep the bots happy.
WebKit Commit Bot
Comment 8 2019-01-28 17:51:09 PST
Comment on attachment 360305 [details] Patch Clearing flags on attachment: 360305 Committed r240628: <https://trac.webkit.org/changeset/240628>
WebKit Commit Bot
Comment 9 2019-01-28 17:51:10 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 10 2019-01-28 17:52:28 PST
<rdar://problem/47618786>
Note You need to log in before you can comment on or make changes to this bug.