Bug 193871

Summary: Move scrolling-tree/fixed-inside-frame.html into scrolling tree tests
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: simon.fraser, tsavell, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch zalan: review+

Description Simon Fraser (smfr) 2019-01-26 11:54:04 PST
Move scrolling-tree/fixed-inside-frame.html into scrolling tree tests
Comment 1 Simon Fraser (smfr) 2019-01-26 11:54:55 PST
Created attachment 360244 [details]
Patch
Comment 2 Simon Fraser (smfr) 2019-01-26 12:56:23 PST
https://trac.webkit.org/changeset/240548/webkit
Comment 3 Radar WebKit Bug Importer 2019-01-26 12:57:27 PST
<rdar://problem/47576122>
Comment 4 Truitt Savell 2019-01-30 15:29:41 PST
Looks like scrollingcoordinator/scrolling-tree/fixed-inside-frame.html

is a flakey failure now after the rename. The old test did not have any expectations. 

History:
https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=scrollingcoordinator%2Fscrolling-tree%2Ffixed-inside-frame.html%20LayoutTests%2Ftiled-drawing%2Fscrolling%2Fframes%2Ffixed-inside-frame.html

Diff:
--- /Volumes/Data/slave/mojave-debug-tests-wk2/build/layout-test-results/scrollingcoordinator/scrolling-tree/fixed-inside-frame-expected.txt
+++ /Volumes/Data/slave/mojave-debug-tests-wk2/build/layout-test-results/scrollingcoordinator/scrolling-tree/fixed-inside-frame-actual.txt
@@ -32,15 +32,15 @@
             (vertical scrollbar mode 0)
             (has enabled vertical scrollbar 1))
           (visual viewport enabled 1)
-          (layout viewport at (0,120) size 465x400)
+          (layout viewport at (0,0) size 465x400)
           (min layout viewport origin (0,0))
           (max layout viewport origin (0,616))
           (behavior for fixed 0)
           (children 1
             (Fixed node
               (anchor edges: AnchorEdgeLeft AnchorEdgeTop)
-              (viewport rect at last layout at (0,120) size 465x400)
-              (layer position at last layout (10,130))
+              (viewport rect at last layout at (0,0) size 465x400)
+              (layer position at last layout (10,10))
             )
           )
         )
@@ -70,7 +70,6 @@
                   (bounds 465.00 400.00)
                   (children 1
                     (GraphicsLayer
-                      (position 0.00 -120.00)
                       (anchor 0.00 0.00)
                       (children 1
                         (GraphicsLayer
@@ -82,7 +81,7 @@
                               (drawsContent 1)
                               (children 1
                                 (GraphicsLayer
-                                  (position 10.00 130.00)
+                                  (position 10.00 10.00)
                                   (bounds 455.00 100.00)
                                   (contentsOpaque 1)
                                   (drawsContent 1)