Bug 193861

Summary:

Web Inspector: Audit: unable to import audits

Product:

WebKit

Reporter:

Devin Rousso <hi>

Component:

Web Inspector

Assignee:

Devin Rousso <hi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, hi, inspector-bugzilla-changes, joepeck, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Bug Depends on:

190754

Bug Blocks:

Attachments:

Description	Flags
Patch	joepeck: review+, commit-queue: commit-queue-
Patch	none

Devin Rousso

Reported 2019-01-25 18:24:36 PST

Attachments
Patch (1.66 KB, patch) 2019-01-25 18:25 PST, Devin Rousso	joepeck: review+ commit-queue: commit-queue-	Details Formatted Diff Diff
Patch (1.70 KB, patch) 2019-01-25 18:45 PST, Devin Rousso	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Devin Rousso

Comment 1 2019-01-25 18:25:56 PST

Created attachment 360203 [details] Patch

Joseph Pecoraro

Comment 2 2019-01-25 18:26:30 PST

Comment on attachment 360203 [details] Patch r=me

WebKit Commit Bot

Comment 3 2019-01-25 18:27:51 PST Comment hidden (obsolete)

Comment on attachment 360203 [details] Patch Rejecting attachment 360203 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 360203, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit /Volumes/Data/EWS/WebKit/Source/WebInspectorUI/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: https://webkit-queues.webkit.org/results/10896382

Devin Rousso

Comment 4 2019-01-25 18:45:12 PST

Created attachment 360209 [details] Patch

WebKit Commit Bot

Comment 5 2019-01-25 19:24:09 PST

Comment on attachment 360209 [details] Patch Clearing flags on attachment: 360209 Committed r240538: <https://trac.webkit.org/changeset/240538>

WebKit Commit Bot

Comment 6 2019-01-25 19:24:11 PST

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 7 2019-01-25 19:25:28 PST

<rdar://problem/47570228>

Note You need to log in before you can comment on or make changes to this bug.