Bug 193837

Summary: <video> elements not in the DOM should be allowed to AirPlay
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, ews-watchlist, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Archive of layout-test-results from ews126 for ios-simulator-wk2
none
Patch for landing none

Description Jer Noble 2019-01-25 11:51:57 PST
<video> elements not in the DOM should be allowed to AirPlay
Comment 1 Jer Noble 2019-01-25 11:52:21 PST
<rdar://42559491>
Comment 2 Jer Noble 2019-01-25 11:55:29 PST
Created attachment 360140 [details]
Patch
Comment 3 Jer Noble 2019-01-25 12:02:03 PST
Created attachment 360141 [details]
Patch
Comment 4 EWS Watchlist 2019-01-25 14:03:18 PST
Comment on attachment 360141 [details]
Patch

Attachment 360141 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/10890511

New failing tests:
media/airplay-allows-buffering.html
Comment 5 EWS Watchlist 2019-01-25 14:03:20 PST
Created attachment 360162 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6
Comment 6 Jer Noble 2019-01-25 17:07:24 PST
(In reply to Build Bot from comment #4)
> Comment on attachment 360141 [details]
> Patch
> 
> Attachment 360141 [details] did not pass ios-sim-ews (ios-simulator-wk2):
> Output: https://webkit-queues.webkit.org/results/10890511
> 
> New failing tests:
> media/airplay-allows-buffering.html

Looks like the testing mock target picker we use for this test doesn't work on the simulator; I'll skip the test before landing.
Comment 7 Jer Noble 2019-01-25 17:09:46 PST
Created attachment 360195 [details]
Patch for landing
Comment 8 WebKit Commit Bot 2019-01-25 17:46:55 PST
Comment on attachment 360195 [details]
Patch for landing

Clearing flags on attachment: 360195

Committed r240537: <https://trac.webkit.org/changeset/240537>
Comment 9 WebKit Commit Bot 2019-01-25 17:46:57 PST
All reviewed patches have been landed.  Closing bug.