| Summary: | Import Resize Observer test cases from WPTs | ||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | cathiechen <cathiechen> | ||||||||||||||||||||||
| Component: | DOM | Assignee: | cathiechen <cathiechen> | ||||||||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||||||||
| Severity: | Normal | CC: | bfulgham, cdumez, commit-queue, ews-feeder, fred.wang, simon.fraser, webkit-bug-importer, zalan | ||||||||||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||||||||
| Bug Depends on: | |||||||||||||||||||||||||
| Bug Blocks: | 157743 | ||||||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||||||
|
Description
cathiechen
2019-01-25 04:11:09 PST
Created attachment 360111 [details]
WIP
Created attachment 360288 [details]
Patch
Created attachment 360289 [details]
Patch
Created attachment 360292 [details]
Patch
Created attachment 360293 [details]
Patch
Created attachment 360294 [details]
Patch
Created attachment 360296 [details]
Patch
Created attachment 360297 [details]
Patch
Created attachment 360321 [details]
Patch
Comment on attachment 360321 [details]
Patch
Can you please only import WPT tests in this patch? Then the addition of runtime ResizeObserver preference as well the local modifications of the tests (to add the header that enables the preference) would be done in follow-up bugs.
Created attachment 360346 [details]
Patch
Comment on attachment 360346 [details] Patch Rejecting attachment 360346 [details] from commit-queue. cathiechen@igalia.com does not have committer permissions according to https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights. Comment on attachment 360346 [details] Patch Clearing flags on attachment: 360346 Committed r240655: <https://trac.webkit.org/changeset/240655> All reviewed patches have been landed. Closing bug. |